[GitHub] [netbeans] lkishalmi commented on a change in pull request #1279: Polishing Gradle HTML UI

[GitBox <gi...@apache.org>]

lkishalmi commented on a change in pull request #1279: Polishing Gradle HTML UI
URL: https://github.com/apache/netbeans/pull/1279#discussion_r289629602
 
 

 ##########
 File path: groovy/gradle/src/org/netbeans/modules/gradle/ActionProviderImpl.java
 ##########
 @@ -250,6 +251,9 @@ private static void invokeProjectAction(final Project project, final ActionMappi
                     prj.reloadProject(true, maxQualily, reloadArgs);
                 }
                 project.getLookup().lookup(AfterBuildActionHook.class).afterAction(action, outerCtx, task.result(), out1);
+                for (TaskListener l : context.lookupAll(TaskListener.class)) {
+                    l.taskFinished(t);
 
 Review comment:
   Well, I would not leak the task out of this context. As far as I see registering an AfterBuildActionHook could do the same as this task listener magic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists