You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/12/03 18:41:50 UTC
[GitHub] [hive] Noremac201 opened a new pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Noremac201 opened a new pull request #1740:
URL: https://github.com/apache/hive/pull/1740
### What changes were proposed in this pull request?
1. Refactor HiveMetastore.HMSHandler into its own class
### Why are the changes needed?
This will pave the way for cleaner changes since now we don't have the driver class nested with 10,000 line HMSHandler file so there is a clearer separation of duties.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing unit tests, building/running manually
Not additional tests were added since this was a pure refactoring
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely removed a comment on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
miklosgergely removed a comment on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740560239
recheck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740561137
@mwalenia please push your changes again to your remote branch, with a new commit having the same content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740560239
recheck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely removed a comment on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
miklosgergely removed a comment on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740559929
retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740559929
retest
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] Noremac201 closed pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
Noremac201 closed pull request #1740:
URL: https://github.com/apache/hive/pull/1740
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] fenglu-g commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
fenglu-g commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-738212050
@nrg4878 and others, PTAL, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] Noremac201 commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
Noremac201 commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-744585214
Superseded by #1777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740652364
Also, please create a feature branch (HIVE-24470) on your local repository and PR from there.
```
git checkout -b HIVE-24470
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mwalenia commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
mwalenia commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740510182
@miklosgergely can you run the tests again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] belugabehr commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740651806
@mwalenia Go ahead and just close the PR manually for 30s and then re-open. That should trigger the tests again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mwalenia commented on pull request #1740: HIVE-24470 - Separate HiveMetastore Thrift and Driver logic
Posted by GitBox <gi...@apache.org>.
mwalenia commented on pull request #1740:
URL: https://github.com/apache/hive/pull/1740#issuecomment-740734192
since I'm not the PR creator, we'll need to wait with this for @Noremac201. Thanks for the tips!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org