You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by sindhurirayavaram <gi...@git.apache.org> on 2017/09/01 23:55:42 UTC
[GitHub] drill pull request #933: DRILL-5765: Json query profile is not shown on Web ...
GitHub user sindhurirayavaram opened a pull request:
https://github.com/apache/drill/pull/933
DRILL-5765: Json query profile is not shown on Web UI
The "graph.js", used in the profiles page of Drill Web UI, uses $(window).load(function () {}). The ".load" function is deprecated from the Jquery after 1.8. In this change, I have changed the function to onload.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sindhurirayavaram/drill bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #933
----
commit 833e69c0b5811449667446b06212016f5925e9cd
Author: Sindhuri Rayavaram <si...@mapr.local>
Date: 2017-09-01T23:51:07Z
DRILL-5765: Json query profile is not shown on Web UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #933: DRILL-5765: Json query profile is not shown on Web ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/933
---
[GitHub] drill issue #933: DRILL-5765: Json query profile is not shown on Web UI
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/933
@sindhurirayavaram can you please explain why your previous changes caused the regression and how they are connected with `load` function. Thank you in advance.
---
[GitHub] drill issue #933: DRILL-5765: Json query profile is not shown on Web UI
Posted by arina-ielchiieva <gi...@git.apache.org>.
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/933
Thanks for explanation. +1
---
[GitHub] drill issue #933: DRILL-5765: Json query profile is not shown on Web UI
Posted by sindhurirayavaram <gi...@git.apache.org>.
Github user sindhurirayavaram commented on the issue:
https://github.com/apache/drill/pull/933
@arina-ielchiieva I updated the jquery to it's latest min version. The updated jquery library doesn't support load function anymore. It should be "onload". We were using load in graph.js which was failing. I updated that to "onload".
---