[GitHub] [commons-vfs] garydgregory commented on a change in pull request #152: Minor Improvement:

[GitBox <gi...@apache.org>]

garydgregory commented on a change in pull request #152:
URL: https://github.com/apache/commons-vfs/pull/152#discussion_r546741060



##########
File path: pom.xml
##########
@@ -65,49 +65,49 @@
     <developer>
       <name>James Strachan</name>
       <id>jstrachan</id>
-      <email>jstrachan -at- apache.org</email>
+      <email>jstrachan@apache.org</email>

Review comment:
       -1 don't fiddle with these please.

##########
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/sftp/test/SftpProviderStreamProxyModeTestCase.java
##########
@@ -32,7 +32,7 @@
 
 import junit.framework.Test;
 
-public class SftpProviderStreamProxyModeTestCase extends AbstractSftpProviderTestCase {
+public class    SftpProviderStreamProxyModeTestCase extends AbstractSftpProviderTestCase {

Review comment:
       Fix formatting.
   

##########
File path: commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/hdfs/test/HdfsFileProviderTest.java
##########
@@ -117,7 +117,7 @@ public static void setUmask(final Configuration conf2) {
             final BufferedReader bri = new BufferedReader(new InputStreamReader(p.getInputStream()));
             final String line = bri.readLine();
             p.waitFor();
-            final Short umask = Short.parseShort(line.trim(), 8);
+            final short umask = Short.parseShort(line.trim(), 8);

Review comment:
       `Short.parseShort(line.trim(), 8)` -> `Short.parseShort(line.trim(), 8).shortValue()` to make unboxing explicit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org