You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "qqu0127 (via GitHub)" <gi...@apache.org> on 2023/05/22 20:39:47 UTC
[GitHub] [helix] qqu0127 commented on a diff in pull request #2502: Fixes #324 - Callback Handler messages
qqu0127 commented on code in PR #2502:
URL: https://github.com/apache/helix/pull/2502#discussion_r1201042554
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -788,9 +792,23 @@ public boolean isReady() {
}
public String getContent() {
- return "CallbackHandler{" + "_watchChild=" + _watchChild + ", _preFetchEnabled="
- + _preFetchEnabled + ", _batchModeEnabled=" + _batchModeEnabled + ", _path='" + _path + '\''
- + ", _listener=" + _listener + ", _changeType=" + _changeType + ", _manager=" + _manager
- + ", _zkClient=" + _zkClient + '}';
+ StringBuilder sb = new StringBuilder("iCallbackHandler{_watchChild=");
Review Comment:
extra i here.
(Did you edit all these in vim? :D
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -747,7 +752,7 @@ public void reset() {
reset(true);
}
- void reset(boolean isShutdown) {
+ public void reset(boolean isShutdown) {
Review Comment:
is this necessary?
##########
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java:
##########
@@ -788,9 +792,23 @@ public boolean isReady() {
}
public String getContent() {
- return "CallbackHandler{" + "_watchChild=" + _watchChild + ", _preFetchEnabled="
- + _preFetchEnabled + ", _batchModeEnabled=" + _batchModeEnabled + ", _path='" + _path + '\''
- + ", _listener=" + _listener + ", _changeType=" + _changeType + ", _manager=" + _manager
- + ", _zkClient=" + _zkClient + '}';
+ StringBuilder sb = new StringBuilder("iCallbackHandler{_watchChild=");
+ sb.append(_watchChild);
+ sb.append(", _preFetchEnabled=");
+ sb.append(_preFetchEnabled);
+ sb.append(", _batchModeEnabled=");
+ sb.append(_batchModeEnabled);
+ sb.append(", _path='");
+ sb.append(_path);
+ sb.append("', _listener=");
Review Comment:
extra '
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org