[GitHub] [incubator-pinot] apucher commented on a change in pull request #7140: Add support to skip tests if docker is not available

[GitBox <gi...@apache.org>]

apucher commented on a change in pull request #7140:
URL: https://github.com/apache/incubator-pinot/pull/7140#discussion_r665945189



##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/RealtimeKinesisIntegrationTest.java
##########
@@ -208,15 +221,11 @@ public void startKinesis()
       throws Exception {
     try {
       final LocalstackDockerConfiguration dockerConfig = PROCESSOR.process(this.getClass());
-      localstackDocker.startup(dockerConfig);
-    } catch (LocalstackDockerException e) {
       StopAllLocalstackDockerCommand stopAllLocalstackDockerCommand = new StopAllLocalstackDockerCommand();
       stopAllLocalstackDockerCommand.execute();
-
-      final LocalstackDockerConfiguration dockerConfig = PROCESSOR.process(this.getClass());
-      //Restart localstack docker after killing all the existing localstack docker containers.
-      //If it fails at this step, the test is terminated.
       localstackDocker.startup(dockerConfig);
+    } catch (LocalstackDockerException e) {

Review comment:
       just skip the catch here and throw the exception up the stack?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org