You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/01 10:56:09 UTC
[GitHub] [lucene-solr] NazerkeBS opened a new pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
NazerkeBS opened a new pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278
…lugins.json
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `master` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] NazerkeBS commented on a change in pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on a change in pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#discussion_r567865869
##########
File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java
##########
@@ -149,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
rsp.add( "security", getSecurityInfo(req) );
rsp.add( "system", getSystemInfo() );
if (solrCloudMode) {
- rsp.add("node", getCoreContainer(req, core).getZkController().getNodeName());
+ rsp.add(PARAM_NODE, getCoreContainer(req, core).getZkController().getNodeName());
Review comment:
PARAM_NODE is initialized but not used in this class. Then I thought it can be used here;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] NazerkeBS closed pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
NazerkeBS closed pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] NazerkeBS commented on pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#issuecomment-865763786
closing this PR and I will create another PR on the main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#issuecomment-770869469
Can you update `solr-upgrade-notes.adoc` to say which paths are no longer registered at each Solr Core level yet remain at the node level? Also see if you spot the existing documentation on these mentioning that these handlers are at the core level. Hopefully no such docs but I didn't look.
Also, you can add a CHANGES.txt entry for 9.0 under "Other" with this info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#issuecomment-801347988
Just a gentle reminder of this one. I'm sure you're busy with configSet refactoring but I didn't want this completely forgotten.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#discussion_r567880375
##########
File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java
##########
@@ -149,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
rsp.add( "security", getSecurityInfo(req) );
rsp.add( "system", getSystemInfo() );
if (solrCloudMode) {
- rsp.add("node", getCoreContainer(req, core).getZkController().getNodeName());
+ rsp.add(PARAM_NODE, getCoreContainer(req, core).getZkController().getNodeName());
Review comment:
Okay but that doesn't mean it should be used in a non-param way.
Let's not touch SystemInfoHandler or it's registration in this issue/PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2278: SOLR-15124: Remove node/container level admin handlers from ImplicitP…
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #2278:
URL: https://github.com/apache/lucene-solr/pull/2278#discussion_r567811574
##########
File path: solr/core/src/resources/ImplicitPlugins.json
##########
@@ -66,29 +66,13 @@
"class": "solr.LukeRequestHandler",
"useParams":"_ADMIN_LUKE"
},
- "/admin/system": {
Review comment:
I think we can't get away with this; the admin UI uses it and perhaps other parts of Solr? Did you try bringing up Solr with this change and using the admin UI to click on specific cores?
##########
File path: solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java
##########
@@ -149,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req, SolrQueryResponse rsp) throw
rsp.add( "security", getSecurityInfo(req) );
rsp.add( "system", getSystemInfo() );
if (solrCloudMode) {
- rsp.add("node", getCoreContainer(req, core).getZkController().getNodeName());
+ rsp.add(PARAM_NODE, getCoreContainer(req, core).getZkController().getNodeName());
Review comment:
PARAM_NODE is called that because it's a _parameter_. It's use here in a response structure is dubious because it's not a parameter. Other keys of the response above just use static strings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org