You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/18 15:25:48 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

ijuma commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1026569181


##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -214,14 +214,14 @@ object TestUtils extends Logging {
     enableToken: Boolean = false,
     numPartitions: Int = 1,
     defaultReplicationFactor: Short = 1,
-    startingIdNumber: Int = 0
-  ): Seq[Properties] = {
+    startingIdNumber: Int = 0,
+    enableFetchFromFollower: Boolean = false): Seq[Properties] = {

Review Comment:
   This method has far too many parameters, it doesn't make sense to add parameters for every single possible configuration. Instead, you can add whatever property you want to the returned `Properties` instance.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org