[jira] [Commented] (AMQ-7270) Queue's copyMatchingMessages effects setMaxPageSize in error

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-7270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902241#comment-16902241 ] 

ASF subversion and git services commented on AMQ-7270:
------------------------------------------------------

Commit fb2296ac7447c4e2bfba806ad419ec2c2c2ada8d in activemq's branch refs/heads/master from gtully
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=fb2296a ]

AMQ-7270 - remove toggle on maxPageSize, request page in of entire queue only when cache is in play or broker is non persistent, fix and test


> Queue's copyMatchingMessages effects setMaxPageSize in error
> ------------------------------------------------------------
>
>                 Key: AMQ-7270
>                 URL: https://issues.apache.org/jira/browse/AMQ-7270
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.15.0
>            Reporter: Gary Tully
>            Assignee: Gary Tully
>            Priority: Major
>             Fix For: 5.16.0
>
>
> The copyMatchingMessages jmx op toggles the destination maxPageSize attribute. It should not do this b/c it is not thread safe and can effect other paging operations like dispatch and purge.
> In addition, concurrent calls to copyMatchingMessages can leave the value at queueDepth.
> For large queues, have the maxPageSize == queueDepth means we try and page in the entire queue, leading to an OOM.
> For non persistent brokers or where all messages are cached, it is sensible to attempt to reference all of the messages in the queue, however in general respecting the maxPageSize is advisable.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)