You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/18 21:04:59 UTC
[GitHub] [lucene] rmuir opened a new pull request, #903: LUCENE-10579: fix smoketester backwards-check to not parse stdout
rmuir opened a new pull request, #903:
URL: https://github.com/apache/lucene/pull/903
This is very noisy, can contain gradle status updates, various other `tests.verbose` prints from other threads, you name it.
It causes the check to be flaky, and randomly "miss" seeing a test that executed.
Instead, let's look at the zip files. We can still preserve the essence of what the test wants to do, but without any flakiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #903: LUCENE-10579: fix smoketester backwards-check to not parse stdout
Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #903:
URL: https://github.com/apache/lucene/pull/903#issuecomment-1130814798
See JIRA issue for more background and example data files: https://issues.apache.org/jira/browse/LUCENE-10579
When reviewing the code, it may not be obvious that currently we are parsing a very-noisy **28.4MB** of stdout today, with multiple processes and threads all printing to it. Then we are parsing it with regular expressions. It makes the parsing flaky.
Rather than run the test with `-Dtests.verbose=true` and try to parse thru megabytes of this stuff, we can just list the .zip files that the test uses. We still list all `*.cfs` files basically, and let the smoketester deal with all the comparisons it currently does against the apache archive.
This is basically the minimal fix, of course we could implement the test completely differently, but I kinda like its heroic efforts to cross-check apache archive releases against our backwards compatibility tests. I just don't want it flaky as smoketests take hours for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #903: LUCENE-10579: fix smoketester backwards-check to not parse stdout
Posted by GitBox <gi...@apache.org>.
rmuir merged PR #903:
URL: https://github.com/apache/lucene/pull/903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org