[GitHub] rfscholte commented on a change in pull request #14: Exclude non-exported packages when Java Modules are present.

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #14: Exclude non-exported packages when Java Modules are present.
URL: https://github.com/apache/maven-javadoc-plugin/pull/14#discussion_r243901929
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
 ##########
 @@ -4342,6 +4351,102 @@ private void copyAdditionalJavadocResources( File anOutputDirectory )
         return getPackageNamesOrFilesWithUnnamedPackages( sourcePaths, files, true );
     }
 
+    /**
+     * @param allSourcePaths     not null, containing absolute and relative paths
+     * @return a list of exported package names for files in allSourcePaths
+     * @throws MavenReportException if any
+     * @see #getFiles
+     * @see #getSourcePaths()
+     */
+    private List<String> getPackageNamesRespectingJavaModules( Map<String, Collection<String>> allSourcePaths )
+            throws MavenReportException
+    {
+        List<String> returnList = new ArrayList<>();
+
+        if ( !StringUtils.isEmpty( sourcepath ) )
+        {
+            return returnList;
+        }
+        LocationManager locationManager = new LocationManager();
 
 Review comment:
   I hope we can refactor the code, so the locationManager is used only once per goal-call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services