You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp> on 2006/07/04 08:34:27 UTC
[PATCH] Update CHANGES.
Hi,
To push ahead the 1.4.x releasing process even if only slightly, I try
updating the CHANGES file by adding entries for some recently merged
revisions. Here is a patch. Since I've never done such a work,
I'll be very happy if some reviews and comments are presented, such as
"This entry is not necessary" or "This entry should be written here"...
Thanks,
-nori
[[[
* CHANGES: Add entries for some recently merged revisions. Also,
correct an entry by changing its revision number from one for merging
to the 1.4.x branch to one for modification to the trunk.
]]]
Re: [PATCH] Update CHANGES (r19924)
Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/12/06, Malcolm Rowe <ma...@farside.org.uk> wrote:
> On Tue, Jul 11, 2006 at 01:16:24PM -0600, D.J. Heap wrote:
> > >None of those seem worthy of a note in CHANGES by themselves, but I
> > >had thought that the change was to fix a specific bug, in which case we
> > >_should_ mention it. However, that requires that we can work out what
> > >the bug was :-)
> > >
> >
> > [snip]
> >
> > So, basically, Subversion on Win32 with Apache 2.2.x will now work if
> > you apply the apr patch (or if it is fixed in apr someday).
> >
>
> Thanks. It doesn't sound like that's worth an entry in CHANGES then,
> though I would have thought that it's worthwhile noting the incompatibilty
> with APR 1.x on win32 in INSTALL somewhere?
>
Yes, good idea -- in fact, INSTALL for Win32 needs quite a bit of
updating. Lots of dependency versions have changed, several things
now are optional that didn't used to be, etc. I'll try to get to it
when I can.
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Update CHANGES (r19924)
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Tue, Jul 11, 2006 at 01:16:24PM -0600, D.J. Heap wrote:
> >None of those seem worthy of a note in CHANGES by themselves, but I
> >had thought that the change was to fix a specific bug, in which case we
> >_should_ mention it. However, that requires that we can work out what
> >the bug was :-)
> >
>
> [snip]
>
> So, basically, Subversion on Win32 with Apache 2.2.x will now work if
> you apply the apr patch (or if it is fixed in apr someday).
>
Thanks. It doesn't sound like that's worth an entry in CHANGES then,
though I would have thought that it's worthwhile noting the incompatibilty
with APR 1.x on win32 in INSTALL somewhere?
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Update CHANGES.
Posted by "D.J. Heap" <dj...@gmail.com>.
On 7/11/06, Malcolm Rowe <ma...@farside.org.uk> wrote:
> On Wed, Jul 12, 2006 at 02:17:08AM +0900, Kobayashi Noritada wrote:
> > > > +* deal with perms and attributes correctly on unix and Win32 (r19924)
> > >
> > > I think this was a fix to a problem, so should be soemthing like 'fixed:
> > > <whatever the problem was>'.
> >
> > I think this was correcting attributes setting on Win32 just like permission
> > handling on unix, but did it fix anything...?
> > Should we keep this change undocumented?
> >
>
> I tried to understand what this was doing myself. It seems like
> we're deprecating svn_io_set_file_read_write_carefully() and fixing
> svn_io_set_file_read_only(), svn_io_set_file_read_write(), and
> svn_io_set_file_executable() to work better on Windows.
>
> None of those seem worthy of a note in CHANGES by themselves, but I
> had thought that the change was to fix a specific bug, in which case we
> _should_ mention it. However, that requires that we can work out what
> the bug was :-)
>
Yes, there was a long thread about it that crossed apr and Subversion
mailing lists.
The issue is getting Subversion to work on Win32 with apr > 0.9.x.
This was just one of several fixes to Subversion to get it working (in
this case, Subversion was treating the read-only attribute as a
permission which it is not and apr doesn't even support changing
permissions on Win32 anyway).
Subversion on Win32 with apr > 0.9.x continues to not work, however,
due to a still-existing bug in apr > 0.9.x where incomplete file
information is returned on stat calls. There has been a patch for it
for the last 9 months or so that looks like it soon may actually get
applied...maybe. With that small patch to apr, Subversion on Win32
with Apache 2.2.2 is working well and passing all tests.
So, basically, Subversion on Win32 with Apache 2.2.x will now work if
you apply the apr patch (or if it is fixed in apr someday).
DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Update CHANGES.
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Wed, Jul 12, 2006 at 02:17:08AM +0900, Kobayashi Noritada wrote:
> > > +* deal with perms and attributes correctly on unix and Win32 (r19924)
> >
> > I think this was a fix to a problem, so should be soemthing like 'fixed:
> > <whatever the problem was>'.
>
> I think this was correcting attributes setting on Win32 just like permission
> handling on unix, but did it fix anything...?
> Should we keep this change undocumented?
>
I tried to understand what this was doing myself. It seems like
we're deprecating svn_io_set_file_read_write_carefully() and fixing
svn_io_set_file_read_only(), svn_io_set_file_read_write(), and
svn_io_set_file_executable() to work better on Windows.
None of those seem worthy of a note in CHANGES by themselves, but I
had thought that the change was to fix a specific bug, in which case we
_should_ mention it. However, that requires that we can work out what
the bug was :-)
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Update CHANGES.
Posted by Kobayashi Noritada <no...@dolphin.c.u-tokyo.ac.jp>.
Hi,
Sorry for misupdating my patch and thank you very much for updating
CHANGES instead of me at r20557. I was trying to understand the
background of r19924 and looking for a way to describe it...
> > +* deal with perms and attributes correctly on unix and Win32 (r19924)
>
> I think this was a fix to a problem, so should be soemthing like 'fixed:
> <whatever the problem was>'.
I think this was correcting attributes setting on Win32 just like permission
handling on unix, but did it fix anything...?
Should we keep this change undocumented?
Thanks,
-nori
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Update CHANGES.
Posted by Malcolm Rowe <ma...@farside.org.uk>.
On Tue, Jul 04, 2006 at 05:34:27PM +0900, Kobayashi Noritada wrote:
> +* require APR 0.9.x >= 0.9.7 to avoid FSFS repository corruption (r19915)
This isn't really user-visible - move to the developer section? And I'd
drop the 'to avoid...' line - while we are forcing APR 0.9.7 to ensure
that we always get error returns from buffered writes, there are reports
of corruption with APR >= 0.9.7, and I wouldn't like to imply that we've
fixed the problem entirely.
> +* explicitly destroy the svnserve connection pool in forking mode (r19992)
This will be reverted by brane's BDB fix, I think.
> +* widen SWIG requirement to 1.3.29 (r19968)
'support SWIG 1.3.29'?
> +* deal with perms and attributes correctly on unix and Win32 (r19924)
I think this was a fix to a problem, so should be soemthing like 'fixed:
<whatever the problem was>'.
Regards,
Malcolm
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org