You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/15 14:24:04 UTC

[GitHub] [airflow] ashb commented on issue #15372: Set region flag before making getJob API call in AwsGlueJobHook

ashb commented on issue #15372:
URL: https://github.com/apache/airflow/issues/15372#issuecomment-820462016


   Looking at the code, the `region_name` from the AwsGlueOperator is handled in the constructor -- none of the _methods_ in the Aws hooks should take a region_name parameter.
   
   And the operator take a region_name https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/_api/airflow/providers/amazon/aws/operators/glue/index.html?highlight=glue#airflow.providers.amazon.aws.operators.glue.AwsGlueJobOperator and passes it on, so from looking at the code, it should work like this:
   
   - If an explicit region_name is passed via the operator, that is used
   - If not, the default from whatever connection is used is taken.
   - All access via the AwsGlueHook should already respect the `self.region_name` property of the hook.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org