You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2013/01/04 15:17:37 UTC
Re: Slim-down effort: current situation
I was reading this article and suddenly thought: why not giving access to branches in OFBiz project to people who need more than a patch to submit in a Jira (clearly Tom and I would have loved that)?
http://prng.blogspot.fr/2009/02/commit-access-its-social-problem.html
Opinions?
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
> Yes thanks!
>
> Jacques
>
> From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
>>
>> On Dec 16, 2012, at 9:07 AM, Jacques Le Roux wrote:
>>
>>> I even wonder if Jacopo did not make a more recent (and flexible) proposition with which I totaly agreed (during fall, it seems to me but, I can't find it), Jacopo?
>>
>> Do you mean the following?
>>
>> ========================
>> BTW, some time ago I also proposed an alternative path: see email with subject "[PROPOSAL] from specialpurpose to extras": to that I can add that we could provide two set of ant scripts, one similar to the one we have that builds/tests everything (framework+applications+specialpurpose) and one (the default) that only builds/tests the framework+applications; the release branches may only contain the framework+applications and separate releases of specialpurpose applications could be voted/released at different time. This approach may reach two goals:
>> 1) slim down the "main" code that the community is more focused to improve/maintain/release
>> 2) keep under the OFBiz community the ownership of all the other specialpurpose components; if one of them will get more attention and interest and could grow in quality or it is generic enough we could decide to move it to the release branch (maybe move it to applications)
>> ========================
>>
>> Jacopo
>>
>>
>
Re: Slim-down effort: current situation
Posted by Anil Patel <an...@hotwaxmedia.com>.
One of the solutions is to create brach on github, https://github.com/apache/ofbiz. A feature can be developed on Github and then a final patch can be submitted to Ofbiz Jira.
Regards
Anil Patel
On Jan 4, 2013, at 9:17 AM, Jacques Le Roux <ja...@les7arts.com> wrote:
> I was reading this article and suddenly thought: why not giving access to branches in OFBiz project to people who need more than a patch to submit in a Jira (clearly Tom and I would have loved that)?
> http://prng.blogspot.fr/2009/02/commit-access-its-social-problem.html
>
> Opinions?
>
> Jacques
>
> From: "Jacques Le Roux" <ja...@les7arts.com>
>> Yes thanks!
>>
>> Jacques
>>
>> From: "Jacopo Cappellato" <ja...@hotwaxmedia.com>
>>>
>>> On Dec 16, 2012, at 9:07 AM, Jacques Le Roux wrote:
>>>
>>>> I even wonder if Jacopo did not make a more recent (and flexible) proposition with which I totaly agreed (during fall, it seems to me but, I can't find it), Jacopo?
>>>
>>> Do you mean the following?
>>>
>>> ========================
>>> BTW, some time ago I also proposed an alternative path: see email with subject "[PROPOSAL] from specialpurpose to extras": to that I can add that we could provide two set of ant scripts, one similar to the one we have that builds/tests everything (framework+applications+specialpurpose) and one (the default) that only builds/tests the framework+applications; the release branches may only contain the framework+applications and separate releases of specialpurpose applications could be voted/released at different time. This approach may reach two goals:
>>> 1) slim down the "main" code that the community is more focused to improve/maintain/release
>>> 2) keep under the OFBiz community the ownership of all the other specialpurpose components; if one of them will get more attention and interest and could grow in quality or it is generic enough we could decide to move it to the release branch (maybe move it to applications)
>>> ========================
>>>
>>> Jacopo
>>>
>>>
>>
Re: Slim-down effort: current situation
Posted by Jacques Le Roux <ja...@les7arts.com>.
A bit out of subject, I found this article interesting http://kohsuke.org/2013/01/04/the-other-side-of-forking-and-pull-requests
And he made me wonder how the OpenErp project is handling its addons (some years ago someone told me this was a weak part of the project, I never dug)
Jacques
From: "Jacques Le Roux" <ja...@les7arts.com>
> From: <de...@me.com>
>> On Jan 5, 2013, at 1:47 PM, Jacques Le Roux <ja...@les7arts.com> wrote:
>>
>>> From: "Ean Schuessler" <ea...@brainfood.com>
>>>> I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted.
>>>> I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository.
>>>
>>> Depends, if committer/s follow/s the work closely then it can be a could way to share until the work is finished. I don't see what GitHub adds to this.
>>>
>>>> The nice thing about GIT is that the chaff doesn't get into the wheat bucket.
>>>
>>> Don't make sense to me. In svn branches in OFBiz repo if the work is of low quality, and dropping a branch is only few clicks.
>>> If the work is of low quality in GitHub it will be ignored as well.
>>>
>>> If the work is of good quality, why wait to have it in GitHub in the meantime and not directly in a svn branch?
>>>
>>> I still really don't see what GitHub brings here... apart (for me at leat) learning to use Git
>>
>> Can we even restrict commit access to branches in the ASF SVN any more? We moved away from restricted access to framework versus applications a long time ago due to pressure from infra/others, and I'm not sure if we can so easily make someone a committer to just a branch.
>
> I'd have to check that, but I believe once well (and very politely ;o) explained it should be possible to convince them
>
>> With GitHub we don't need to do anything, anyone can create a public or private fork of OFBiz and change it all they want. People can also still extract patches across multiple commits so it's not so much work to apply them. It's really a much better approach.
>
> Of course, as you said it's already there, so we have nothing to do, nothing happens.
>
> Jacques
>
>> -David
>>
>
Re: Slim-down effort: current situation
Posted by Jacques Le Roux <ja...@les7arts.com>.
From: <de...@me.com>
> On Jan 5, 2013, at 1:47 PM, Jacques Le Roux <ja...@les7arts.com> wrote:
>
>> From: "Ean Schuessler" <ea...@brainfood.com>
>>> I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted.
>>> I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository.
>>
>> Depends, if committer/s follow/s the work closely then it can be a could way to share until the work is finished. I don't see what GitHub adds to this.
>>
>>> The nice thing about GIT is that the chaff doesn't get into the wheat bucket.
>>
>> Don't make sense to me. In svn branches in OFBiz repo if the work is of low quality, and dropping a branch is only few clicks.
>> If the work is of low quality in GitHub it will be ignored as well.
>>
>> If the work is of good quality, why wait to have it in GitHub in the meantime and not directly in a svn branch?
>>
>> I still really don't see what GitHub brings here... apart (for me at leat) learning to use Git
>
> Can we even restrict commit access to branches in the ASF SVN any more? We moved away from restricted access to framework versus applications a long time ago due to pressure from infra/others, and I'm not sure if we can so easily make someone a committer to just a branch.
I'd have to check that, but I believe once well (and very politely ;o) explained it should be possible to convince them
> With GitHub we don't need to do anything, anyone can create a public or private fork of OFBiz and change it all they want. People can also still extract patches across multiple commits so it's not so much work to apply them. It's really a much better approach.
Of course, as you said it's already there, so we have nothing to do, nothing happens.
Jacques
> -David
>
Re: Slim-down effort: current situation
Posted by de...@me.com.
On Jan 5, 2013, at 1:47 PM, Jacques Le Roux <ja...@les7arts.com> wrote:
> From: "Ean Schuessler" <ea...@brainfood.com>
>> I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted.
>> I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository.
>
> Depends, if committer/s follow/s the work closely then it can be a could way to share until the work is finished. I don't see what GitHub adds to this.
>
>> The nice thing about GIT is that the chaff doesn't get into the wheat bucket.
>
> Don't make sense to me. In svn branches in OFBiz repo if the work is of low quality, and dropping a branch is only few clicks.
> If the work is of low quality in GitHub it will be ignored as well.
>
> If the work is of good quality, why wait to have it in GitHub in the meantime and not directly in a svn branch?
>
> I still really don't see what GitHub brings here... apart (for me at leat) learning to use Git
Can we even restrict commit access to branches in the ASF SVN any more? We moved away from restricted access to framework versus applications a long time ago due to pressure from infra/others, and I'm not sure if we can so easily make someone a committer to just a branch.
With GitHub we don't need to do anything, anyone can create a public or private fork of OFBiz and change it all they want. People can also still extract patches across multiple commits so it's not so much work to apply them. It's really a much better approach.
-David
Re: Slim-down effort: current situation
Posted by Jacques Le Roux <ja...@les7arts.com>.
From: "Ean Schuessler" <ea...@brainfood.com>
> I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted.
>I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository.
Depends, if committer/s follow/s the work closely then it can be a could way to share until the work is finished. I don't see what GitHub adds to this.
>The nice thing about GIT is that the chaff doesn't get into the wheat bucket.
Don't make sense to me. In svn branches in OFBiz repo if the work is of low quality, and dropping a branch is only few clicks.
If the work is of low quality in GitHub it will be ignored as well.
If the work is of good quality, why wait to have it in GitHub in the meantime and not directly in a svn branch?
I still really don't see what GitHub brings here... apart (for me at leat) learning to use Git
Jacques
> ----- "Jacques Le Roux" wrote:
>> Because it's possibly easier for committers to follow the work done and not get a big patch at the end.
>> With Git you tend to receive either a burst of patches or a big one, both in one shoot.
>> Then it's hard to review the work done. By steps it's easier
>> I don't use GitHub, I have enough to do with OFBiz patches already...
>
> --
> Ean Schuessler, CTO
> ean@brainfood.com
> 214-720-0700 x 315
> Brainfood, Inc.
> http://www.brainfood.com
>
Re: Slim-down effort: current situation
Posted by Ean Schuessler <ea...@brainfood.com>.
I don't know that its much worse. On GitHub you will see the forks and could track their changes if you wanted. I think the complication with handing out SVN branches is that we will end up with a lot of low quality branches in the core repository. The nice thing about GIT is that the chaff doesn't get into the wheat bucket.
----- "Jacques Le Roux" wrote:
> Because it's possibly easier for committers to follow the work done and not get a big patch at the end.
> With Git you tend to receive either a burst of patches or a big one, both in one shoot.
> Then it's hard to review the work done. By steps it's easier
> I don't use GitHub, I have enough to do with OFBiz patches already...
--
Ean Schuessler, CTO
ean@brainfood.com
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com
Re: Slim-down effort: current situation
Posted by Jacques Le Roux <ja...@les7arts.com>.
Because it's possibly easier for committers to follow the work done and not get a big patch at the end.
With Git you tend to receive either a burst of patches or a big one, both in one shoot.
Then it's hard to review the work done. By steps it's easier
I don't use GitHub, I have enough to do with OFBiz patches already...
Jacques
From: "Ean Schuessler" <ea...@brainfood.com>
> Why wouldn't they just fork and then issue a pull request on GitHub?
>
> ----- "Jacques Le Roux" wrote:
>> I was reading this article and suddenly thought: why not giving access to branches in OFBiz project to people who need more than a patch to submit in a Jira (clearly Tom and I would have loved that)?
>> http://prng.blogspot.fr/2009/02/commit-access-its-social-problem.html
>
> --
> Ean Schuessler, CTO
> ean@brainfood.com
> 214-720-0700 x 315
> Brainfood, Inc.
> http://www.brainfood.com
>
Re: Slim-down effort: current situation
Posted by Ean Schuessler <ea...@brainfood.com>.
Why wouldn't they just fork and then issue a pull request on GitHub?
----- "Jacques Le Roux" wrote:
> I was reading this article and suddenly thought: why not giving access to branches in OFBiz project to people who need more than a patch to submit in a Jira (clearly Tom and I would have loved that)?
> http://prng.blogspot.fr/2009/02/commit-access-its-social-problem.html
--
Ean Schuessler, CTO
ean@brainfood.com
214-720-0700 x 315
Brainfood, Inc.
http://www.brainfood.com