[jira] [Commented] (CASSANDRA-5591) Window failure renaming LCS json.

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666361#comment-13666361 ] 

Jonathan Ellis commented on CASSANDRA-5591:
-------------------------------------------

I don't see anything obviously wrong here:

{code}
        if (oldFile.exists() && manifestFile.exists())
            FileUtils.deleteWithConfirm(oldFile);

        if (manifestFile.exists())
            FileUtils.renameWithConfirm(manifestFile, oldFile);
{code}

(The {{serialize}} method is synchronized, so we shouldn't be racing with anyone here either.)
                
> Window failure renaming LCS json.
> ---------------------------------
>
>                 Key: CASSANDRA-5591
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5591
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: Windows
>            Reporter: Jeremiah Jordan
>
> Had someone report that on Windows, under load, the LCS json file sometimes fails to be renamed.
> {noformat}
> ERROR [CompactionExecutor:1] 2013-05-23 14:43:55,848 CassandraDaemon.java (line 174) Exception in thread Thread[CompactionExecutor:1,1,main]
>  java.lang.RuntimeException: Failed to rename C:\development\tools\DataStax Community\data\data\zzz\zzz\zzz.json to C:\development\tools\DataStax Community\data\data\zzz\zzz\zzz-old.json
> 	at org.apache.cassandra.io.util.FileUtils.renameWithConfirm(FileUtils.java:133)
> 	at org.apache.cassandra.db.compaction.LeveledManifest.serialize(LeveledManifest.java:617)
> 	at org.apache.cassandra.db.compaction.LeveledManifest.promote(LeveledManifest.java:229)
> 	at org.apache.cassandra.db.compaction.LeveledCompactionStrategy.handleNotification(LeveledCompactionStrategy.java:155)
> 	at org.apache.cassandra.db.DataTracker.notifySSTablesChanged(DataTracker.java:410)
> 	at org.apache.cassandra.db.DataTracker.replaceCompactedSSTables(DataTracker.java:223)
> 	at org.apache.cassandra.db.ColumnFamilyStore.replaceCompactedSSTables(ColumnFamilyStore.java:991)
> 	at org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:230)
> 	at org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48)
> 	at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> 	at org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:58)
> 	at org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:60)
> 	at org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:188)
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
> 	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
> 	at java.lang.Thread.run(Thread.java:662)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira