You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2016/01/14 09:53:54 UTC
Review Request 42293: FALCON-1715 IllegalStateException in
MetadataMappingService when entity is scheduled via native scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42293/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1715
https://issues.apache.org/jira/browse/FALCON-1715
Repository: falcon-git
Description
-------
The error is because Falcon server is run as "user1" and entities are being submitted as "user2" (how it should be) and in native scheduler, Oozie workflow run is done as current logged in user. This happens to be "user1" since Falcon process is the one that is running the workflow. This should be changed to use "user2", the owner of the entity to address the problem.
Diffs
-----
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
Diff: https://reviews.apache.org/r/42293/diff/
Testing
-------
Reproduced the problem and ensured it doesn't occur after the patch.
Thanks,
Pallavi Rao
Re: Review Request 42293: FALCON-1715 IllegalStateException in
MetadataMappingService when entity is scheduled via native scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Jan. 14, 2016, 9:26 a.m., pavan kumar kolamuri wrote:
> > scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java, line 115
> > <https://reviews.apache.org/r/42293/diff/1/?file=1196584#file1196584line115>
> >
> > There is also getConfiguration() method using switchUser that will be used by all API's. Shouldn't we change over there.
Intentionally left that unchanged. The getConfiguration is used to retrieve job info and we should do that as "falcon user" (owner of Falcon server process).
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42293/#review114445
-----------------------------------------------------------
On Jan. 14, 2016, 8:53 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42293/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 8:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1715
> https://issues.apache.org/jira/browse/FALCON-1715
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The error is because Falcon server is run as "user1" and entities are being submitted as "user2" (how it should be) and in native scheduler, Oozie workflow run is done as current logged in user. This happens to be "user1" since Falcon process is the one that is running the workflow. This should be changed to use "user2", the owner of the entity to address the problem.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
>
> Diff: https://reviews.apache.org/r/42293/diff/
>
>
> Testing
> -------
>
> Reproduced the problem and ensured it doesn't occur after the patch.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 42293: FALCON-1715 IllegalStateException in
MetadataMappingService when entity is scheduled via native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42293/#review114445
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java (line 115)
<https://reviews.apache.org/r/42293/#comment175292>
There is also getConfiguration() method using switchUser that will be used by all API's. Shouldn't we change over there.
- pavan kumar kolamuri
On Jan. 14, 2016, 8:53 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42293/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 8:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1715
> https://issues.apache.org/jira/browse/FALCON-1715
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The error is because Falcon server is run as "user1" and entities are being submitted as "user2" (how it should be) and in native scheduler, Oozie workflow run is done as current logged in user. This happens to be "user1" since Falcon process is the one that is running the workflow. This should be changed to use "user2", the owner of the entity to address the problem.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
>
> Diff: https://reviews.apache.org/r/42293/diff/
>
>
> Testing
> -------
>
> Reproduced the problem and ensured it doesn't occur after the patch.
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 42293: FALCON-1715 IllegalStateException in
MetadataMappingService when entity is scheduled via native scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42293/#review114449
-----------------------------------------------------------
Ship it!
Ship It!
- pavan kumar kolamuri
On Jan. 14, 2016, 8:53 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42293/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 8:53 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1715
> https://issues.apache.org/jira/browse/FALCON-1715
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The error is because Falcon server is run as "user1" and entities are being submitted as "user2" (how it should be) and in native scheduler, Oozie workflow run is done as current logged in user. This happens to be "user1" since Falcon process is the one that is running the workflow. This should be changed to use "user2", the owner of the entity to address the problem.
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/workflow/engine/OozieDAGEngine.java 1d0e126
>
> Diff: https://reviews.apache.org/r/42293/diff/
>
>
> Testing
> -------
>
> Reproduced the problem and ensured it doesn't occur after the patch.
>
>
> Thanks,
>
> Pallavi Rao
>
>