[jira] Commented: (TOMAHAWK-5) newspaperTable should be merged with dataTable.

["Mike Kienenberger (JIRA)" <de...@myfaces.apache.org>]

    [ http://issues.apache.org/jira/browse/TOMAHAWK-5?page=comments#action_12383252 ] 

Mike Kienenberger commented on TOMAHAWK-5:
------------------------------------------

Ok.   I've made a first-pass attempt to merge newspaperTable into t:dataTable.
This version works for me, but I'm not sure that it supports all of the extended datatable features yet (ie, newspaper columns and details/grouping/sorting in there may not work together, but both should still work separately).

There were a lot of unexpected changes I had to make to the row style and column style api in order to merge these two together, so it's possible that this patch might break something in there.

So far, I've been testing it with facelets, so as of yet, there's no  jsp tag and tld support -- it should be trivial to add it in.

This is pretty cool in that all you need to do is change t:newspaperTable to t:dataTable, and it "just works" :)


> newspaperTable should be merged with dataTable.
> -----------------------------------------------
>
>          Key: TOMAHAWK-5
>          URL: http://issues.apache.org/jira/browse/TOMAHAWK-5
>      Project: MyFaces Tomahawk
>         Type: Bug

>   Components: Newspaper Table
>  Environment: Windows XP, JBOSS
>     Reporter: Dave
>     Assignee: Mike Kienenberger
>  Attachments: Shared-HtmlTableRenderer.java.patch-2006-05-12-00.txt, Tomahawk-HtmlDataTable.java.patch-2006-05-12-00.txt, Tomahawk-HtmlTableRenderer.java.patch-2006-05-12-00.txt, Tomahawk-NewspaperTable.java.patch-2006-05-12-00.txt
>
> newspaperTable should be merged with dataTable. It should be a property of dataTable.
>  
> <t:dataTable ....
>           newspaperColumns="8"/>
>  
> if the property is 0 or not defined, it is a normal table, otherwise render as newspaper.
>  
> This way it can leverage all features of dataTable such as sorting and dynamic column model, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira