[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1177: MINIFICPP-1644: ProcessSession::read ignores the size/offset of the

[GitBox <gi...@apache.org>]

adamdebreceni commented on a change in pull request #1177:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1177#discussion_r714528530



##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -290,6 +290,33 @@ void ProcessSession::append(const std::shared_ptr<core::FlowFile> &flow, OutputS
   }
 }
 
+namespace {
+// FlowFileStream uses the flowfile's size instead of the stream size (so it will not be over-read)
+class FlowFileStream : public io::BaseStream {

Review comment:
       the only thing we use from the flowfile is the offset and size, I don't think we need to store the flowfile, we could generalize this `FlowFileStream` to a `StreamSlice` taking an offset and size




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org