You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dorx <gi...@git.apache.org> on 2014/07/18 02:25:07 UTC
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
GitHub user dorx opened a pull request:
https://github.com/apache/spark/pull/1473
Fixed a typo in the comments in RangePartitioner
Checked with Holden, the original author as per the log, and was told
code is right comment is wrong.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dorx/spark typoInPartitioner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1473
----
commit 901a595317032114726dc8461b397c635c62ed37
Author: Doris Xin <do...@gmail.com>
Date: 2014-07-18T00:24:24Z
Fixed a typo in the comments in RangePartitioner
Checked with Holden, the original author as per the log, and was told
code is right comment is wrong.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49388392
QA results for PR 1473:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16796/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by dorx <gi...@git.apache.org>.
Github user dorx commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49466619
A superficial look at the failed unit tests seems to suggest some Spark SQL optimizations rely on the fact that 1000 is set as the sequential scan threshhold. @rxin @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by dorx <gi...@git.apache.org>.
Github user dorx closed the pull request at:
https://github.com/apache/spark/pull/1473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49383190
QA tests have started for PR 1473. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16796/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by dorx <gi...@git.apache.org>.
Github user dorx commented on a diff in the pull request:
https://github.com/apache/spark/pull/1473#discussion_r15098158
--- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
@@ -135,7 +135,7 @@ class RangePartitioner[K : Ordering : ClassTag, V](
val k = key.asInstanceOf[K]
var partition = 0
if (rangeBounds.length < 1000) {
--- End diff --
That's why I noticed it in the first place. Would changing this number have unintended affects on people who're currently using the RangePartitioner?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49405021
QA results for PR 1473:<br>- This patch FAILED unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16816/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49539328
I filed a JIRA: https://issues.apache.org/jira/browse/SPARK-2598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1473#discussion_r15098185
--- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
@@ -135,7 +135,7 @@ class RangePartitioner[K : Ordering : ClassTag, V](
val k = key.asInstanceOf[K]
var partition = 0
if (rangeBounds.length < 1000) {
--- End diff --
I don't think so. If anything, it should make it faster.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49400241
QA tests have started for PR 1473. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16816/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49467466
It appears to me that the range partitioner is not correctly using the provided ordering in the case where it uses a binary search.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1473#issuecomment-49539660
@dorx can you close this PR? #1500 includes the change here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Fixed a typo in the comments in RangePartition...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1473#discussion_r15098078
--- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
@@ -135,7 +135,7 @@ class RangePartitioner[K : Ordering : ClassTag, V](
val k = key.asInstanceOf[K]
var partition = 0
if (rangeBounds.length < 1000) {
--- End diff --
Actually 1000 seems a pretty large number for doing linear scan. How about 64 or 128?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---