[jira] [Created] (PHOENIX-5023) Clean up giant anonymous inner classes

["Geoffrey Jacoby (JIRA)" <ji...@apache.org>]

Geoffrey Jacoby created PHOENIX-5023:
----------------------------------------

             Summary: Clean up giant anonymous inner classes
                 Key: PHOENIX-5023
                 URL: https://issues.apache.org/jira/browse/PHOENIX-5023
             Project: Phoenix
          Issue Type: Improvement
            Reporter: Geoffrey Jacoby


A frequent anti-pattern in the Phoenix code base is the use of huge anonymous inner classes, often in the midst of functions that are already very large, or even the parameter list of constructor calls. (The latter means that we have single statements that are technically hundreds of lines long!)  

This makes the logic difficult to follow and prevents abstraction. Modern IDEs make changing these to named inner classes quite simple. 

This is intended as an umbrella item with subtasks refactoring particular classes, which can be added to over time. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)