[GitHub] [ignite-3] sergey-chugunov-1985 commented on a change in pull request #84: IGNITE-14382 Rework network module API structure

[GitBox <gi...@apache.org>]

sergey-chugunov-1985 commented on a change in pull request #84:
URL: https://github.com/apache/ignite-3/pull/84#discussion_r607583972



##########
File path: modules/network/src/main/java/org/apache/ignite/network/Network.java
##########
@@ -17,50 +17,15 @@
 
 package org.apache.ignite.network;
 
-import java.util.Arrays;
-import java.util.Collections;
-import org.apache.ignite.network.message.MessageMapperProvider;
-
 /**
- * Entry point for network module.
+ * Entry point for the network module.
  */
-public class Network {
-    /** Message mapper providers, messageMapperProviders[message type] -> message mapper provider for message with message type. */
-    private final MessageMapperProvider<?>[] messageMapperProviders = new MessageMapperProvider<?>[Short.MAX_VALUE << 1];
-
-    /** Message handlers. */
-    private final MessageHandlerHolder messageHandlerHolder = new MessageHandlerHolder();
-
-    /** Cluster factory. */
-    private final NetworkClusterFactory clusterFactory;
-
-    /**
-     * Constructor.
-     * @param factory Cluster factory.
-     */
-    public Network(NetworkClusterFactory factory) {
-        clusterFactory = factory;
-    }
+public interface Network {

Review comment:
       What about renaming it to `Networking`? It is not ideal either but sounds a bit better to me than plain `Network`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org