You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/06/12 16:11:57 UTC
Review Request: Automation: Network life cycle tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/
-----------------------------------------------------------
Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan.
Description
-------
Changed code related to verifying round robin of ip address allocation.
Diffs
-----
test/integration/smoke/test_network.py a65748d
Diff: https://reviews.apache.org/r/11835/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request: Automation: Network life cycle tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On June 12, 2013, 3:44 p.m., Prasanna Santhanam wrote:
> > test/integration/smoke/test_network.py, line 149
> > <https://reviews.apache.org/r/11835/diff/1/?file=304124#file304124line149>
> >
> > account is not derefenced as account.account anymore. Was this change unintended? All instances of account.account were changed to account only sometime back in all the tests
Hi Prasanna, I have changed all instances of account.account to account and have uploaded new diff.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/#review21797
-----------------------------------------------------------
On June 13, 2013, 10:30 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11835/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 10:30 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan.
>
>
> Description
> -------
>
> Changed code related to verifying round robin of ip address allocation.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 1c867fa
>
> Diff: https://reviews.apache.org/r/11835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request: Automation: Network life cycle tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/#review21797
-----------------------------------------------------------
test/integration/smoke/test_network.py
<https://reviews.apache.org/r/11835/#comment44975>
account is not derefenced as account.account anymore. Was this change unintended? All instances of account.account were changed to account only sometime back in all the tests
- Prasanna Santhanam
On June 12, 2013, 2:11 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11835/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 2:11 p.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan.
>
>
> Description
> -------
>
> Changed code related to verifying round robin of ip address allocation.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py a65748d
>
> Diff: https://reviews.apache.org/r/11835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request: Automation: Network life cycle tests
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/#review21859
-----------------------------------------------------------
Ship it!
ed1980c7417216efa541c978d4233391d1659b79
- Prasanna Santhanam
On June 13, 2013, 10:30 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11835/
> -----------------------------------------------------------
>
> (Updated June 13, 2013, 10:30 a.m.)
>
>
> Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan.
>
>
> Description
> -------
>
> Changed code related to verifying round robin of ip address allocation.
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 1c867fa
>
> Diff: https://reviews.apache.org/r/11835/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request: Automation: Network life cycle tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11835/
-----------------------------------------------------------
(Updated June 13, 2013, 10:30 a.m.)
Review request for cloudstack, Prasanna Santhanam and Rayees Namathponnan.
Changes
-------
Changed instances of "account.account" to "account".
Description
-------
Changed code related to verifying round robin of ip address allocation.
Diffs (updated)
-----
test/integration/smoke/test_network.py 1c867fa
Diff: https://reviews.apache.org/r/11835/diff/
Testing
-------
Thanks,
Gaurav Aradhye