You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by n-tran <gi...@git.apache.org> on 2015/12/22 01:45:12 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP-983 - Provide a way to...
GitHub user n-tran opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/184
TINKERPOP-983 - Provide a way to track open Graph instances in tests
Doing a test PR to see if Travis will build, there might be something wrong with my local environment. If Travis doesn't pass, I will rescind my PR.
Refactor tests to use member variables for `graphProvider`
Added Java docs
https://issues.apache.org/jira/browse/TINKERPOP-983
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP-983
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 0926604ecdfcf5c9ece592f94470df7d3434c701
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-12-02T00:18:42Z
Refactor tests to use member variables for graphProvider
commit 947d192e682fb1a3c9470c87bed8b4cebf69a60e
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-12-06T22:25:34Z
Initial development to track open graph instances in the tests.
Neo4j is currently not passing
commit 2c07233e98561a9609ea17ea7a24cf49fc6261fe
Author: Nghia Tran <ng...@gmail.com>
Date: 2015-12-22T00:27:57Z
Added Java docs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-983 - Provide a way to...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/184#issuecomment-166580595
Not sure why travis didn't pick this up for build, but I pulled the changes and it failed for me too. It's a subtle problem, but the fix is to add this method to your `ManagedGraphProvider`:
```java
@Override
public String getWorkingDirectory() {
return innerGraphProvider.getWorkingDirectory();
}
```
Without that, HDFS gets the wrong directory and the assert fails. Please try that and see if it fixes your problem with the build. If all good, please update your PR and we can review in full.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-983 - Provide a way to...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/184#issuecomment-167875370
Yeah, looks good.
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-983 - Provide a way to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-983 - Provide a way to...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/184#issuecomment-167824756
VOTE +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-983 - Provide a way to...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/184#issuecomment-167773779
All good with:
```text
mvn clean install -DincludeNeo4j && mvn verify -DskipIntegrationTests=false -DincludeNeo4j
```
The approach makes sense to me. Not sure how else it could be done short of placing the burden on providers to ensure that open `Graph` implementations were tracked.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---