You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/06/05 05:55:16 UTC

[GitHub] [incubator-streampark] tisonkun opened a new pull request, #2791: [Improve] Upgrade Scala patch versions to build on JDK 17

tisonkun opened a new pull request, #2791:
URL: https://github.com/apache/incubator-streampark/pull/2791

   ## What changes were proposed in this pull request
   
   See https://github.com/sbt/sbt/issues/5509 and https://github.com/sbt/sbt/issues/5093.
   
   Otherwise, build with JDK 17 will fail with:
   
   ```
   /packages cannot be represented as URI
   ```
   
   I suppose upgrading patch versions of Scala should not affect end-user's experience.
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (yes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] tisonkun commented on pull request #2791: [Improve] Upgrade Scala patch versions to build on JDK 17

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2791:
URL: https://github.com/apache/incubator-streampark/pull/2791#issuecomment-1576632311

   It seems failed steadily. I may try to investigate a bit later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #2791: [Improve] Upgrade Scala patch versions to build on JDK 17

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on PR #2791:
URL: https://github.com/apache/incubator-streampark/pull/2791#issuecomment-1576740657

   > > PodTemplateParserTest.testHostAliasSpecToPodTemplate:253->$anonfun$testHostAliasSpecToPodTemplate$1$adapted:253->$anonfun$testHostAliasSpecToPodTemplate$1:255 expected: <apiVersion: v1
   > 
   > This failure may not be related to this patch?
   > 
   > cc @wolfboys @Al-assad
   
   This failure is not related to the current PR. We can merge this PR first


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys merged pull request #2791: [Improve] Upgrade Scala patch versions to build on JDK 17

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2791:
URL: https://github.com/apache/incubator-streampark/pull/2791


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] tisonkun commented on pull request #2791: [Improve] Upgrade Scala patch versions to build on JDK 17

Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2791:
URL: https://github.com/apache/incubator-streampark/pull/2791#issuecomment-1576354975

   > PodTemplateParserTest.testHostAliasSpecToPodTemplate:253->$anonfun$testHostAliasSpecToPodTemplate$1$adapted:253->$anonfun$testHostAliasSpecToPodTemplate$1:255 expected: <apiVersion: v1
   
   This failure may not be related to this patch?
   
   cc @wolfboys @Al-assad 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org