You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/11/18 12:59:34 UTC

[GitHub] [fineract] adamsaghy commented on a diff in pull request #2748: FINERACT-1724: Swagger fix for loan transaction API

adamsaghy commented on code in PR #2748:
URL: https://github.com/apache/fineract/pull/2748#discussion_r1026405579


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResourceSwagger.java:
##########
@@ -185,6 +185,38 @@ private GetLoanTransactionRelation() {}
         @Schema(example = "[2012, 5, 18]")
         public LocalDate possibleNextRepaymentDate;
         public Set<GetLoanTransactionRelation> transactionRelations;
+        public PaymentDetailData paymentDetailData;
+
+        static final class PaymentDetailData {
+
+            private PaymentDetailData() {}
+
+            @Schema(example = "62")
+            public Integer id;

Review Comment:
   Please change this to Long (it will match with the DTO/entity type)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org