[GitHub] nickwallen commented on a change in pull request #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

[GitBox <gi...@apache.org>]

nickwallen commented on a change in pull request #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72
URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#discussion_r256384677
 
 

 ##########
 File path: src/KafkaWriter.cc
 ##########
 @@ -66,16 +66,7 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
 }
 
 KafkaWriter::~KafkaWriter()
-{
-
-    // Cleanup all the things
-    delete topic;
-    delete producer;
-    delete formatter;
-    delete conf;
-    delete topic_conf;
-
-}
+{}
 
 Review comment:
   Can we add a comment here to the effect of "clean-up needs to happen in DoFinish, not here." Hopefully that will help us avoid stepping into this trap again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services