You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2020/02/26 04:54:35 UTC
[Issue 128307] New: Picture toolbar, icons for flipping -
misimplementation
https://bz.apache.org/ooo/show_bug.cgi?id=128307
Issue ID: 128307
Issue Type: DEFECT
Summary: Picture toolbar, icons for flipping -
misimplementation
Product: Writer
Version: 4.1.7
Hardware: PC
OS: Windows 7
Status: UNCONFIRMED
Severity: Normal
Priority: P5 (lowest)
Component: ui
Assignee: issues@openoffice.apache.org
Reporter: czeslaw.wolanski@gmail.com
Target Milestone: ---
Created attachment 86854
--> https://bz.apache.org/ooo/attachment.cgi?id=86854&action=edit
Writer document for tests
In AOO Writer open attached file "testFile". You shall see two identical
images: one at the top of page, second one at its bottom.
If that top image is not selected, do it. Picture toolbar will appear.
--------------------- TEST no. 1 ---------------------
Steps to reproduce:
1. Click "Flip Horizontally" icon
You will notice that image is flipped horizontally
and icon remains SELECTED.
2. Click "Flip Vertically" icon
You will notice that image is flipped vertically
and icon remains SELECTED.
So we have now two icons selected. Notice that both toolbar and menu show the
same information
(see attachment called Test_1).
Something here is VERY WRONG. Neither of these icons should act like this. It
seems they work in toggle mode.
(pushbutton, Uno API > UnoControlButtonModel, property .Toggle).
I run some tests in AOO Draw and spotted a difference.
Started to dig dipper into this bug.
You will find the result of my research below.
Behaviour of two "icons" is ABSOLUTELY WRONG for at least two reasons:
1. Flip horizontally/vertically should - as any software for image
processing would do - perform a simple operation. By toggling
the state of icon, AOO Writer does something more.
-------------------- TEST no. 2 ----------------------------------
(see my attachment called Test_2)
(a) start from scratch i.e. in situation when neither "Flip
Horizontally" nor "Flip Vertically" is selected
For this you can use second image located at the bottom of page.
(b) click "Flip Vertically" icon
Vertical flipping takes place.
(c) invert image
Click icon "Magic Wand" on the Picture toolbar.
In "Graphic Filter" window click icon "Invert".
Notice that image was not only inverted.
(d) undo this operation
click "Undo" icon on Standard toolbar OR Edit > Undo
You surely will notice that image has NOT returned to state
in point (b) but to state in point (a). You will see same result
if in point (b) icon "Flip Horizontally" is choosen.
VERY BAD indeed.
2. In AOO Draw there are four commands available in dialog
"Add Command":
"Flip Horizontally","Flip Vertically",
"Horizontally" and "Vertically".
I have created a custom toolbar "myToolbar". It contains all of them.
(see attached image "myToolbar")
I have attached .odg file "testFile_1"
That toolbar is stored therein.
If not visible, choose: View > Toolbars > myToolbar
In tests: no. 1 and no. 2 above all icons behave CORRECTLY.
Why? Because in contrast to AOO Writer they do not remain selected
once clicked.
And now take a look at juxtaposition of commands available
in dialog "Add command" in AOO Writer and AOO Draw
(see attachment called "Juxtaposition")
Tools > Options > Customize > tabpage Toolbar > Add
In AOO Draw: commands: "Horizontally" & "Vertically" are in Category
"Modify".
Notice that icons are NOT available.
Notice that correct description is given.
commands "Flip Vertically" and "Flip Horizontally"
are in category "Format"
Notice that icons are available.
Notice lacking description for both commands.
In AOO Writer: commands "Flip Horizontally" and "Flip Vertically"
are in category "Format"
Notice that icons are available.
Notice mistake in description for both commands.
In category "Modify" there is neither "Horizontally" nor
"Vertically" command.
RECAPITULATION -------------------------------------------------------
1. Inconsistency between AOO Writer and AOO Draw is evident and not
trivial.
2. Behaviour of "Flip Horizontally" and "Flip Vertically" icons
in AOO Writer is ABSOLUTELY WRONG. Their counterparts in AOO Draw
behave as expected.
Please take care of this. As of now it defies logic.
Spoils consistency between AOO components.
Is misleading and annoying too.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128307] Picture toolbar, icons for flipping -
misimplementation
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128307
--- Comment #3 from Czesław Wolański <cz...@gmail.com> ---
Created attachment 86857
--> https://bz.apache.org/ooo/attachment.cgi?id=86857&action=edit
Screenshot for Test no. 2
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128307] Picture toolbar, icons for flipping -
misimplementation
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128307
--- Comment #1 from Czesław Wolański <cz...@gmail.com> ---
Created attachment 86855
--> https://bz.apache.org/ooo/attachment.cgi?id=86855&action=edit
Writer and Draw comands
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128307] Picture toolbar, icons for flipping -
misimplementation
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128307
--- Comment #5 from Czesław Wolański <cz...@gmail.com> ---
Created attachment 86859
--> https://bz.apache.org/ooo/attachment.cgi?id=86859&action=edit
Draw file for tests
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128307] Picture toolbar, icons for flipping -
misimplementation
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128307
--- Comment #4 from Czesław Wolański <cz...@gmail.com> ---
Created attachment 86858
--> https://bz.apache.org/ooo/attachment.cgi?id=86858&action=edit
Screenshot of custom toolbar in Draw
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 128307] Picture toolbar, icons for flipping -
misimplementation
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=128307
--- Comment #2 from Czesław Wolański <cz...@gmail.com> ---
Created attachment 86856
--> https://bz.apache.org/ooo/attachment.cgi?id=86856&action=edit
Screenshots for Test no. 1
--
You are receiving this mail because:
You are the assignee for the issue.