You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mrunit.apache.org by db...@apache.org on 2013/04/23 11:50:21 UTC
git commit: MRUNIT-185 - IllegalFormatException for % in Output.
Contributed by Joseph Beard.
Updated Branches:
refs/heads/trunk aa44d5406 -> 6e94cecff
MRUNIT-185 - IllegalFormatException for % in Output. Contributed by Joseph Beard.
Project: http://git-wip-us.apache.org/repos/asf/mrunit/repo
Commit: http://git-wip-us.apache.org/repos/asf/mrunit/commit/6e94cecf
Tree: http://git-wip-us.apache.org/repos/asf/mrunit/tree/6e94cecf
Diff: http://git-wip-us.apache.org/repos/asf/mrunit/diff/6e94cecf
Branch: refs/heads/trunk
Commit: 6e94cecfff1986807ef2f5c1e735c7857f6b57a7
Parents: aa44d54
Author: Dave Beech <da...@paraliatech.com>
Authored: Tue Apr 23 10:48:58 2013 +0100
Committer: Dave Beech <da...@paraliatech.com>
Committed: Tue Apr 23 10:48:58 2013 +0100
----------------------------------------------------------------------
.../apache/hadoop/mrunit/internal/util/Errors.java | 8 ++++++++
.../hadoop/mrunit/internal/util/TestErrors.java | 8 ++++++++
2 files changed, 16 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mrunit/blob/6e94cecf/src/main/java/org/apache/hadoop/mrunit/internal/util/Errors.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/hadoop/mrunit/internal/util/Errors.java b/src/main/java/org/apache/hadoop/mrunit/internal/util/Errors.java
index bb3eeb4..b47cf54 100644
--- a/src/main/java/org/apache/hadoop/mrunit/internal/util/Errors.java
+++ b/src/main/java/org/apache/hadoop/mrunit/internal/util/Errors.java
@@ -44,6 +44,14 @@ public class Errors {
/**
* Log a new error message and keep it for later.
*/
+ public void record(String message) {
+ log.error(message);
+ messages.add(message);
+ }
+
+ /**
+ * Log a new error message and keep it for later.
+ */
public void record(String format, Object... args) {
final String message = String.format(format, args);
log.error(message);
http://git-wip-us.apache.org/repos/asf/mrunit/blob/6e94cecf/src/test/java/org/apache/hadoop/mrunit/internal/util/TestErrors.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/hadoop/mrunit/internal/util/TestErrors.java b/src/test/java/org/apache/hadoop/mrunit/internal/util/TestErrors.java
index a0819ca..c53e942 100644
--- a/src/test/java/org/apache/hadoop/mrunit/internal/util/TestErrors.java
+++ b/src/test/java/org/apache/hadoop/mrunit/internal/util/TestErrors.java
@@ -50,6 +50,14 @@ public class TestErrors {
}
@Test
+ public void shouldUseLiteralMessageWhenNoArguments() {
+ thrown.expectMessage("2 Error(s): (this is a %s error, this is a %d error)");
+ errors.record("this is a %s error");
+ errors.record("this is a %d error");
+ errors.assertNone();
+ }
+
+ @Test
public void shouldBuildAssertionErrorMessageWithRecordedErrors() {
thrown.expectMessage("2 Error(s): (this is a first error, this is a second error)");
errors.record("this is a %s error", "first");