[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2921: diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP

[GitBox <gi...@apache.org>]

kangkaisen commented on a change in pull request #2921: diable column both in select list and aggregate functions when using GROUPING SETS/CUBE/ROLLUP
URL: https://github.com/apache/incubator-doris/pull/2921#discussion_r379995223
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/SelectStmt.java
 ##########
 @@ -349,6 +350,19 @@ public void analyze(Analyzer analyzer) throws AnalysisException, UserException {
             }
         }
         if (groupByClause != null && groupByClause.isGroupByExtension()) {
+            for (SelectListItem item : selectList.getItems()) {
 
 Review comment:
   Please Add a UT. Currently we have a FE UT frame, which could handle SQL analyze bug. you could refer to `DemoTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org