You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by kw...@apache.org on 2019/05/05 04:32:50 UTC
[impala] 03/04: IMPALA-8492: reenable large string tests in docker
This is an automated email from the ASF dual-hosted git repository.
kwho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 23d7a6dce6ce4287edf20e3f63b225822cb88598
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Fri May 3 12:12:41 2019 -0700
IMPALA-8492: reenable large string tests in docker
IMPALA-4865 is fixed so these now pass. I noticed
that the IMPALA-4874 test occasionally hit
"Memory Limit Exceeded" when looped, so I reduced
the data size there slightly.
Testing:
Looped the tests locally against a dockerised minicluster
for a while.
Change-Id: I030f4eff2d3fb771fc92b760efb13170e68285dc
Reviewed-on: http://gerrit.cloudera.org:8080/13233
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
.../workloads/functional-query/queries/QueryTest/large_strings.test | 5 ++---
tests/common/skip.py | 2 --
tests/query_test/test_insert.py | 1 -
tests/query_test/test_queries.py | 1 -
4 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/testdata/workloads/functional-query/queries/QueryTest/large_strings.test b/testdata/workloads/functional-query/queries/QueryTest/large_strings.test
index 0cca71b..9df5a50 100644
--- a/testdata/workloads/functional-query/queries/QueryTest/large_strings.test
+++ b/testdata/workloads/functional-query/queries/QueryTest/large_strings.test
@@ -219,12 +219,11 @@ from (
select cast(fnv_hash(concat(l_comment, 'a')) as string) as h from tpch_parquet.lineitem union all
select cast(fnv_hash(concat(l_comment, 'b')) as string) as h from tpch_parquet.lineitem union all
select cast(fnv_hash(concat(l_comment, 'c')) as string) as h from tpch_parquet.lineitem union all
-select cast(fnv_hash(concat(l_comment, 'd')) as string) as h from tpch_parquet.lineitem union all
-select cast(fnv_hash(concat(l_comment, 'e')) as string) as h from tpch_parquet.lineitem) a;
+select cast(fnv_hash(concat(l_comment, 'd')) as string) as h from tpch_parquet.lineitem) a;
---- TYPES
INT,INT
---- RESULTS
-611468161,611468161
+489174530,489174530
=====
---- QUERY
select repeat('the quick brown fox', 1024 * 1024 * 100)
diff --git a/tests/common/skip.py b/tests/common/skip.py
index cad1caa..646695b 100644
--- a/tests/common/skip.py
+++ b/tests/common/skip.py
@@ -192,8 +192,6 @@ class SkipIfDockerizedCluster:
IS_DOCKERIZED_TEST_CLUSTER, reason="Daemon logs not exposed in host.")
accesses_host_filesystem = pytest.mark.skipif(
IS_DOCKERIZED_TEST_CLUSTER, reason="Daemon would need to access host filesystem.")
- jvm_oom_large_string = pytest.mark.skipif(IS_DOCKERIZED_TEST_CLUSTER,
- reason="IMPALA-4865: JVM hits OOM for large string. Heap is smaller in docker.")
insert_acls = pytest.mark.skipif(IS_DOCKERIZED_TEST_CLUSTER,
reason="IMPALA-8384: insert ACL tests are broken on dockerised minicluster.")
diff --git a/tests/query_test/test_insert.py b/tests/query_test/test_insert.py
index a55fdbe..5014156 100644
--- a/tests/query_test/test_insert.py
+++ b/tests/query_test/test_insert.py
@@ -80,7 +80,6 @@ class TestInsertQueries(ImpalaTestSuite):
v.get_value('compression_codec') == 'none'))
@pytest.mark.execute_serially
- @SkipIfDockerizedCluster.jvm_oom_large_string
def test_insert_large_string(self, vector, unique_database):
"""Test handling of large strings in inserter and scanner."""
if "-Xcheck:jni" in os.environ.get("LIBHDFS_OPTS", ""):
diff --git a/tests/query_test/test_queries.py b/tests/query_test/test_queries.py
index 2a44fce..d156212 100644
--- a/tests/query_test/test_queries.py
+++ b/tests/query_test/test_queries.py
@@ -204,7 +204,6 @@ class TestQueriesParquetTables(ImpalaTestSuite):
return 'functional-query'
@SkipIfEC.oom
- @SkipIfDockerizedCluster.jvm_oom_large_string
@pytest.mark.execute_serially
def test_very_large_strings(self, vector):
"""Regression test for IMPALA-1619. Doesn't need to be run on all file formats.