You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by filmaj <gi...@git.apache.org> on 2017/07/11 17:32:51 UTC
[GitHub] cordova-android pull request #394: CB-13006: replace create end-to-end tests...
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/394
CB-13006: replace create end-to-end tests with unit tests
There were create end-to-end tests that validated use of unicode, spaces and ascii characters in project names and destination paths. These tests were HEAVY - they would shell out to create _and_ compile each one, and there were 6 of these tests. Additionally, these tests would regularly time out on Travis.
Instead, this PR replaces those tests with lighter weight unit tests exercising the same logic (hopefully).
*NOTE*: by removing the create end-to-end tests, we now no longer test that created projects can compile using the Android SDK. We may want to consider adding a basic smoke-test for this back into the end-to-end tests.
Please review / discuss / FYI @infil00p, @stevengill, @dpogue, @alsorokin, @matrosov-nikita, @jcesarmobile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/filmaj/cordova-android CB-13006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit 41c24a8ae1f3415d3fc0bdc6f6fd00fa7075a15a
Author: filmaj <ma...@gmail.com>
Date: 2017-07-11T17:25:12Z
CB-13006: removed create end-to-end tests, and instead added more unit test coverage. tweaked code coverage invocation so that we get coverage details on the create.js module. slight changes to the create.js module so that it is slightly easier to test.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #394: CB-13006: replace create end-to-end tests with u...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/394
It seems like removing the create e2e tests, which regularly time out, just pushed the timeouts to the upgrade e2e tests. I believe it has something to do with the first test that compiles the project needing to kick up the gradle daemon and warm up the caches.
Will remove those tests as well - we've talked about doing that regardless.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #394: CB-13006: replace create end-to-end tests with u...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/394
This also sped up CI runtimes:
- AppVeyor: ~9 mins to ~4 mins
- Travis: ~12 mins to ~8 mins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #394: CB-13006: replace create end-to-end tests...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-android/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #394: CB-13006: replace create end-to-end tests with u...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/394
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=h1) Report
> Merging [#394](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/90053eb9dfc03c6cdab31aab665324556c3358be?src=pr&el=desc) will **increase** coverage by `1%`.
> The diff coverage is `72.72%`.
[](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #394 +/- ##
========================================
+ Coverage 41.54% 42.55% +1%
========================================
Files 16 17 +1
Lines 1497 1678 +181
Branches 279 304 +25
========================================
+ Hits 622 714 +92
- Misses 875 964 +89
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `50.82% <72.72%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=footer). Last update [90053eb...5917d4e](https://codecov.io/gh/apache/cordova-android/pull/394?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org