You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/27 18:10:27 UTC
[GitHub] [cordova-paramedic] erisu opened a new pull request #215: Feat/gh actions
erisu opened a new pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215
### Motivation and Context
Migrate paramedic to GH Actions
- Appium tests are not passing but everything else is running OK. No core plugins uses Appium test for android.
### Testing
- Chrome: https://github.com/erisu/cordova-paramedic/actions/runs/1175154254
- Android: https://github.com/erisu/cordova-paramedic/actions/runs/1175195391
- iOS: https://github.com/erisu/cordova-paramedic/actions/runs/1175154252
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] erisu commented on pull request #215: ci: migrate to gh-actions
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215#issuecomment-907582515
As for the `Q` usage, I think we should remove it but on a separate PR. The rest of the code base is using `Q`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] zachawilson commented on pull request #215: ci: migrate to gh-actions
Posted by GitBox <gi...@apache.org>.
zachawilson commented on pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215#issuecomment-907491400
This is looking good to me.
As additional testing, I have forked and run a GitHub Action workflows for `cordova-plugin-statusbar` using this `cordova-paramedic` at the latest commit 2dbc650
- android https://github.com/SwitchCaseGroup/cordova-plugin-statusbar/runs/3447269881
- ios https://github.com/SwitchCaseGroup/cordova-plugin-statusbar/actions/runs/1175705680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] erisu merged pull request #215: ci: add gh-actions workflow
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] dpogue commented on a change in pull request #215: ci: migrate to gh-actions
Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215#discussion_r697823229
##########
File path: lib/appium/AppiumRunner.js
##########
@@ -339,6 +340,7 @@ function getPackagePath (options) {
case utilities.ANDROID:
let packagePath = null;
const maybePackagePaths = [
+ path.join(fullAppPath, 'platforms/android/app/build/outputs/apk/debug/app-debug.apk'),
Review comment:
This should pass the path components separately (like the other two below) so that they use the correct path separator on all OSes
##########
File path: .github/workflows/android.yml
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Android Testsuite
+
+on: [push, pull_request]
+
+jobs:
+ test:
+ name: Android Latest Test
+ runs-on: macos-latest
Review comment:
It _should_ in theory be possible to run the Android stuff on `ubuntu` instead of `macos`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] erisu commented on a change in pull request #215: ci: migrate to gh-actions
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215#discussion_r697824672
##########
File path: lib/appium/AppiumRunner.js
##########
@@ -339,6 +340,7 @@ function getPackagePath (options) {
case utilities.ANDROID:
let packagePath = null;
const maybePackagePaths = [
+ path.join(fullAppPath, 'platforms/android/app/build/outputs/apk/debug/app-debug.apk'),
Review comment:
```suggestion
path.join(fullAppPath, 'platforms', 'android', 'app', 'build', 'outputs', 'apk', 'debug', 'app-debug.apk'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] erisu commented on a change in pull request #215: ci: migrate to gh-actions
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215#discussion_r697824040
##########
File path: lib/appium/AppiumRunner.js
##########
@@ -339,6 +340,7 @@ function getPackagePath (options) {
case utilities.ANDROID:
let packagePath = null;
const maybePackagePaths = [
+ path.join(fullAppPath, 'platforms/android/app/build/outputs/apk/debug/app-debug.apk'),
Review comment:
> The path.join() method joins all given path segments together using the platform-specific separator as a delimiter, then normalizes the resulting path.
It should convert to the correct path separator for each platform.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-paramedic] erisu commented on a change in pull request #215: ci: migrate to gh-actions
Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #215:
URL: https://github.com/apache/cordova-paramedic/pull/215#discussion_r697824297
##########
File path: .github/workflows/android.yml
##########
@@ -0,0 +1,90 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Android Testsuite
+
+on: [push, pull_request]
+
+jobs:
+ test:
+ name: Android Latest Test
+ runs-on: macos-latest
Review comment:
> Can I use this action on Linux VMs?
>
> The short answer is yes but on Github-hosted Linux runners it's expected to be a much worse experience (on some newer API levels it might not work at all) than running it on macOS. You can get it running much faster on self-hosted Linux runners but only if the underlying instances support KVM (which most don't).
>
> For a longer answer please refer to this https://github.com/ReactiveCircus/android-emulator-runner/issues/46.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org