You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/29 12:12:57 UTC

[GitHub] [spark] srowen commented on a change in pull request #24713: [SPARK-26192][MESOS][2.4] Retrieve enableFetcherCache option from submission for driver URIs

srowen commented on a change in pull request #24713: [SPARK-26192][MESOS][2.4] Retrieve enableFetcherCache option from submission for driver URIs
URL: https://github.com/apache/spark/pull/24713#discussion_r288532830
 
 

 ##########
 File path: resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
 ##########
 @@ -129,4 +129,22 @@ package object config {
         "when launching drivers. Default is to accept all offers with sufficient resources.")
       .stringConf
       .createWithDefault("")
+
+  private[spark] val MAX_DRIVERS =
+    ConfigBuilder("spark.mesos.maxDrivers").intConf.createWithDefault(200)
 
 Review comment:
   Although it's not crazy to backport small enhancements, I'd not backport this change. 3.0 changes most all of the configs to use ConfigBuilder, but I don't necessarily think we want to change just a few of them in 2.4, just out of general consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org