You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2017/12/03 01:03:08 UTC
[38/50] [abbrv] thrift git commit: Fix remote client for HTTP
transport Client: go
Fix remote client for HTTP transport
Client: go
Assign parsedUrl to the variable in the outer scope instead of creating
a new one. Previously the outer parsedUrl was never assigned and was
therefore always empty.
This closes #1411
Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/cde4d418
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/cde4d418
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/cde4d418
Branch: refs/heads/0.11.0
Commit: cde4d4181a252323d87e7ac086ce495cd1227c5c
Parents: 39eaae6
Author: Dylan Trotter <tr...@users.noreply.github.com>
Authored: Tue Nov 7 09:56:17 2017 -0800
Committer: James E. King, III <jk...@apache.org>
Committed: Mon Nov 20 07:34:01 2017 -0500
----------------------------------------------------------------------
compiler/cpp/src/thrift/generate/t_go_generator.cc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/thrift/blob/cde4d418/compiler/cpp/src/thrift/generate/t_go_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/thrift/generate/t_go_generator.cc b/compiler/cpp/src/thrift/generate/t_go_generator.cc
index e869b00..6cce32b 100644
--- a/compiler/cpp/src/thrift/generate/t_go_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_go_generator.cc
@@ -2130,7 +2130,7 @@ void t_go_generator::generate_service_remote(t_service* tservice) {
f_remote << indent() << "var urlString string" << endl;
f_remote << indent() << "var framed bool" << endl;
f_remote << indent() << "var useHttp bool" << endl;
- f_remote << indent() << "var parsedUrl url.URL" << endl;
+ f_remote << indent() << "var parsedUrl *url.URL" << endl;
f_remote << indent() << "var trans thrift.TTransport" << endl;
f_remote << indent() << "_ = strconv.Atoi" << endl;
f_remote << indent() << "_ = math.Abs" << endl;
@@ -2147,7 +2147,8 @@ void t_go_generator::generate_service_remote(t_service* tservice) {
f_remote << indent() << "flag.Parse()" << endl;
f_remote << indent() << endl;
f_remote << indent() << "if len(urlString) > 0 {" << endl;
- f_remote << indent() << " parsedUrl, err := url.Parse(urlString)" << endl;
+ f_remote << indent() << " var err error" << endl;
+ f_remote << indent() << " parsedUrl, err = url.Parse(urlString)" << endl;
f_remote << indent() << " if err != nil {" << endl;
f_remote << indent() << " fmt.Fprintln(os.Stderr, \"Error parsing URL: \", err)" << endl;
f_remote << indent() << " flag.Usage()" << endl;