You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/03 07:29:58 UTC

[jira] [Commented] (BEAM-1239) Update examples to use Beam text source

    [ https://issues.apache.org/jira/browse/BEAM-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794392#comment-15794392 ] 

ASF GitHub Bot commented on BEAM-1239:
--------------------------------------

GitHub user chamikaramj opened a pull request:

    https://github.com/apache/beam/pull/1728

    [BEAM-1239] Updates Python SDK examples to use Beam text source

    Currently many Python SDK examples use Dataflow native text source. This updates examples to use Beam text source available in textio.py.
    
    Additionally this updates usages of text sink to use textio.WriteToText() instead of io.TextFileSink (latter usage is deprecated).
    
    This does not update snippets.py which contain tests that dynamically modify source/sink for testing which is hard to do for custom text sink. That should be fixed in a separate CL.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chamikaramj/incubator-beam update_examples_to_use_text_source

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1728
    
----
commit 702a1d27089ba4df59c5b986923a50e7865e7a84
Author: Chamikara Jayalath <ch...@google.com>
Date:   2017-01-03T07:21:05Z

    Updates Python SDK examples to use Beam text source/sink.

----


> Update examples to use Beam text source
> ---------------------------------------
>
>                 Key: BEAM-1239
>                 URL: https://issues.apache.org/jira/browse/BEAM-1239
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>
> Currently many Python SDK examples use Dataflow native text source/sink. They should be updated to use Beam text source/sink available in textio.py.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)