You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org> on 2012/08/15 16:52:38 UTC
[jira] [Created] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Bertrand Guay-Paquet created WICKET-4710:
--------------------------------------------
Summary: DataTable - Headers with OrderByBorder have invalid HTML markup
Key: WICKET-4710
URL: https://issues.apache.org/jira/browse/WICKET-4710
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 6.0.0
Reporter: Bertrand Guay-Paquet
WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
The markup is now:
<th class="wicket_orderUp">
<a class="wicket_orderUp">
<div></div>
</a>
</th>
Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Guay-Paquet updated WICKET-4710:
-----------------------------------------
Attachment: screenshots.png
Screenshot of problem
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439400#comment-13439400 ]
Sven Meier commented on WICKET-4710:
------------------------------------
Why not let the DataTable's cells be <div>s and HeadersToolbar cells be <span>s?
It's a restriction posed by the links in the headers, so the markup can reflect that.
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Sven Meier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439419#comment-13439419 ]
Sven Meier commented on WICKET-4710:
------------------------------------
Then you have to use a custom toolbar.Since the original one uses anchor tags, you can't put block elements in it.
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439344#comment-13439344 ]
Martin Grigorov commented on WICKET-4710:
-----------------------------------------
This became problematic - we cannot use inline element (<span>, WICKET-4224) because users may need to put block inside it, we can't use <wicket:container> because it causes other problems (WICKET-4690) and now this...
I'm not very good in CSS but would it be better if we add style="inline-block" to the <div> ?
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439671#comment-13439671 ]
Bertrand Guay-Paquet commented on WICKET-4710:
----------------------------------------------
Regarding style="inline-block":
As stated on http://www.quirksmode.org/css/display.html, inline-block only works for natural inline elements in IE 7.
TD and TH can contain block elements. The best solution in my opinion would be to find a way to populate TH and TD cells with any component tag directly. This would avoid the question of which intermediate tag type to use. It would also simplify the current situation where adding a simple link or image to a DataTable cell requires creating a whole Panel or Fragment. I'm not sure if/how this can be achieved however...
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440269#comment-13440269 ]
Bertrand Guay-Paquet commented on WICKET-4710:
----------------------------------------------
Sounds good to me!
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4710.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
Assignee: Martin Grigorov
HeadersToolbar.html uses <span> again.
If someone needs to put block elements in the header (s)he will need to provide custom markup for the toolbar.
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Assignee: Martin Grigorov
> Labels: datatable
> Fix For: 6.0.0
>
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435188#comment-13435188 ]
Bertrand Guay-Paquet commented on WICKET-4710:
----------------------------------------------
The problem I describe is problematic when making the OrderByBorder created link the one with the background image and padding to make the icons clickable.
Here is the css I use for the links:
a.wicket_orderNone,a.wicket_orderUp,a.wicket_orderDown {
/* display: block; <--- Must be added with WICKET-4690, but produces bad result of icons far from text */
text-decoration: none;
padding-right: 15px;
}
a.wicket_orderNone {
background: url("images/orderNone.gif") no-repeat center right;
}
...
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439407#comment-13439407 ]
Martin Grigorov commented on WICKET-4710:
-----------------------------------------
What if someone wants to put a block element in the header ?
See for example http://dojofoundation.org/packages/dgrid/demos/gantt/ where a <table> is used for the headers.
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439409#comment-13439409 ]
Martin Grigorov commented on WICKET-4710:
-----------------------------------------
I'm not sure whether <table> is a block element. I just want to say that users could use anything. WICKET-4224 mentions this problem for the headers too.
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4710) DataTable - Headers with
OrderByBorder have invalid HTML markup
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440171#comment-13440171 ]
Martin Grigorov commented on WICKET-4710:
-----------------------------------------
At the moment I see no better solution than Sven's suggestion to use <span> for the headers and <div> for the body.
> DataTable - Headers with OrderByBorder have invalid HTML markup
> ---------------------------------------------------------------
>
> Key: WICKET-4710
> URL: https://issues.apache.org/jira/browse/WICKET-4710
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 6.0.0
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: screenshots.png
>
>
> WICKET-4690 changed the tag type to <div> for the content of DataTable cells. When a sortable column is used, this produces invalid HTML markup which can wreck css stylings.
> The markup is now:
> <th class="wicket_orderUp">
> <a class="wicket_orderUp">
> <div></div>
> </a>
> </th>
> Note the <a> (inline element) containing a <div> (block element)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira