You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/10 12:48:54 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new issue, #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
EricGao888 opened a new issue, #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
* WIP
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274707080
@EricGao888 plz check the issue #12319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] rickchengx commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
rickchengx commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1275710031
Hi, @EricGao888 I want to try microbench and e2e.
* Here is the issue #12333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 closed issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 closed issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
URL: https://github.com/apache/dolphinscheduler/issues/12301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274710230
> @EricGao888 plz check the issue #12319
@fuchanghai done, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1273309329
hi @EricGao888 may i can help to `jUnit4 -> jUnit5 UT cases migration`. any module is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274672989
> > hi @EricGao888 may i can help to `jUnit4 -> jUnit5 UT cases migration`
>
> @fuchanghai Sure, would u like to pick the `dao` module?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274670929
> * dao
@fuchanghai Sure, would u like to pick the `dao` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274665425
hi @EricGao888 may i can help to ``` jUnit4 -> jUnit5 UT cases migration ```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1275739041
> Hi, @EricGao888 I want to try microbench and e2e.
>
> * Here is the issue [[Migration][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in microbench and e2e module #12333](https://github.com/apache/dolphinscheduler/issues/12333)
Sure, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274674358
>
> > hi @EricGao888 may i can help to `jUnit4 -> jUnit5 UT cases migration`. any module is ok
>
> Great! Thanks for the help. Currently I'm estimating the workload. I will divide this issue into sub-tasks by Wednesday. And you are free to choose any sub-task you like to help with this issue at that time : )
@EricGao888 Sure, please check the following issues:
+ [x] Migrate all UT cases from jUnit 4 to jUnit 5 in master, worker and remote module : #12316
+ [x] Migrate all UT cases from jUnit 4 to jUnit 5 in common, service and spi module: #12317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1273295486
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274689683
> >
>
> > > hi @EricGao888 may i can help to `jUnit4 -> jUnit5 UT cases migration`. any module is ok
> >
> >
> > Great! Thanks for the help. Currently I'm estimating the workload. I will divide this issue into sub-tasks by Wednesday. And you are free to choose any sub-task you like to help with this issue at that time : )
>
> @EricGao888 Sure, please check the following issues:
>
> * [x] Migrate all UT cases from jUnit 4 to jUnit 5 in master, worker and remote module : [[Migration][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in master, worker and remote module #12316](https://github.com/apache/dolphinscheduler/issues/12316)
> * [x] Migrate all UT cases from jUnit 4 to jUnit 5 in common, service and spi module: [[Migrate ][Test] Migrate all UT cases from jUnit 4 to jUnit 5 in common, service and spi module #12317](https://github.com/apache/dolphinscheduler/issues/12317)
Sure, I've linked them in the sub-tasks above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] DarkAssassinator commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
DarkAssassinator commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274295166
I can do `master` `worker` `remote` `common` `service` `spi`, and i can take this opportunity to familiarize myself with the source code again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1273314997
> hi @EricGao888 may i can help to `jUnit4 -> jUnit5 UT cases migration`. any module is ok
Great! Thanks for the help. Currently I'm estimating the workload. I will divide this issue into sub-tasks by Wednesday. And you are free to choose any sub-task you like to help with this issue at that time : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #12301: [Migration][Test] jUnit4 -> jUnit5 UT cases migration
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #12301:
URL: https://github.com/apache/dolphinscheduler/issues/12301#issuecomment-1274300301
> I can do `master` `worker` `remote` `common` `service` `spi`, and i can take this opportunity to familiarize myself with the source code again
@DarkAssassinator Sure, feel free! Could u please create two issues and post the links in the comment? I will link them to the `sub-tasks` section. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org