You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/04/26 03:56:22 UTC

[GitHub] [incubator-opendal] Xuanwo opened a new issue, #2125: Add supporting presign support for gcs

Xuanwo opened a new issue, #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125

   Refer to https://github.com/apache/incubator-opendal/issues/2070 for more detials.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1523476610

   > It's so strange. When I use a man-in-the-middle attack tool to intercept network packets and check, it's fine again.
   
   I'm guessing it's related to `pseudo-header :authority` and `host` in `http/2`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] silver-ymz commented on issue #2125: Add supporting presign support for gcs

Posted by "silver-ymz (via GitHub)" <gi...@apache.org>.
silver-ymz commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1522691408

   Ok. I will have a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1523431970

   I have a minimal reproduction case.
   
   ```toml
   [package]
   name = "demo"
   version = "0.1.0"
   edition = "2021"
   
   # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
   
   [dependencies]
   reqwest = { version = "0.11.16", default-features = false, features = [
       "rustls-tls-native-roots",
   ] }
   tokio = { version = "1.28.0", features = ["full"] }
   ```
   
   ```rust
   use reqwest::Client;
   
   #[tokio::main]
   async fn main() {
       let client = Client::new();
   
       let url = "https://storage.googleapis.com/";
       let content = client
           .get(url)
           .body("")
           // Remove this line, everything works..................
           .header("host", "storage.googleapis.com")
           .send()
           .await
           .expect("Failed to send request");
   
       println!("{}", content.text().await.unwrap())
   }
   ```
   
   ```shell
   thread 'main' panicked at 'Failed to send request: reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("storage.googleapis.com")), port: None, path: "/", query: None, fragment: None }, source: hyper::Error(Http2, Error { kind: Reset(StreamId(1), PROTOCOL_ERROR, Remote) }) }', src/main.rs:14:10
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1523375489

   Test failed on default features but can success under `native-tls`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1523377180

   Seems related to `rustls` & `h2`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1522751111

   seems related to reqsign's `sign_query`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1522764035

   The result is different if we are using `native-tls`:
   
   ```rust
   > RUST_LOG=trace cargo test services_gcs::presign_test_presign_read --features=native-tls
   
   thread 'services_gcs::presign_test_presign_read' panicked at 'assertion failed: `(left == right)`
     left: `1810302`,
    right: `800`: read size', core/tests/behavior/presign.rs:165:5
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   [2023-04-26T04:28:13Z TRACE want] signal: Want
   [2023-04-26T04:28:13Z TRACE mio::poll] deregistering event source from poller
   
   
   failures:
       services_gcs::presign_test_presign_read
   ```
   
   Something must be wrong with `rustls` and google.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo closed issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #2125: Add supporting presign support for gcs
URL: https://github.com/apache/incubator-opendal/issues/2125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo closed issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #2125: Add supporting presign support for gcs
URL: https://github.com/apache/incubator-opendal/issues/2125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] suyanhanx commented on issue #2125: Add supporting presign support for gcs

Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1522738949

   Behavior tests failed. https://github.com/apache/incubator-opendal/actions/runs/4804684045/jobs/8550397387


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo closed issue #2125: Add supporting presign support for gcs

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #2125: Add supporting presign support for gcs
URL: https://github.com/apache/incubator-opendal/issues/2125


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] silver-ymz commented on issue #2125: Add supporting presign support for gcs

Posted by "silver-ymz (via GitHub)" <gi...@apache.org>.
silver-ymz commented on issue #2125:
URL: https://github.com/apache/incubator-opendal/issues/2125#issuecomment-1523453647

   It's so strange. When I use a man-in-the-middle attack tool to intercept network packets and check, it's fine again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org