[jira] [Resolved] (YUNIKORN-263) fix lint issues introduced in YUNIKORN-170

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wilfred Spiegelenburg resolved YUNIKORN-263.
--------------------------------------------
    Fix Version/s: 0.9
       Resolution: Fixed

Thank you for the change, commit to work around the issue has been committed.

When we get the new golangci-lint version we can think about reverting the change and use the auto detect again.

> fix lint issues introduced in YUNIKORN-170
> ------------------------------------------
>
>                 Key: YUNIKORN-263
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-263
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>    Affects Versions: 0.9
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Ting Yao,Huang
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 0.9
>
>
> The application CRD is a mixture of generated and written code. We do not want to lint the generated code as that would give false the wrong impression and we really do not want (or can) fix the generated code.
> Propose to add the option {{--skip-dirs pkg/client}} to the lint run to not check the directory but I am not sure if all the code is generated in that dir.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org