You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Prashanth Menon (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/02/05 16:41:53 UTC
[jira] [Issue Comment Edited] (KAFKA-240) implement new producer
and consumer request format
[ https://issues.apache.org/jira/browse/KAFKA-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200660#comment-13200660 ]
Prashanth Menon edited comment on KAFKA-240 at 2/5/12 3:40 PM:
---------------------------------------------------------------
Hi all,
Wasn't able to respond on Friday, but I've just wrapped up the last of the FetchRequest changes. I've attached a patch you can apply to 0.8. All tests should pass. I'll need to coordinate with Joe on how to generate a full patch, or we can leave them separate and have the commiter apply them separately but consecutively.
Details:
1. FetchRequest completely modified along with associatd java type.
2. New FetchResponse, TopicData and PartitionData classes. The latter *Data classes can be shared with the producer side as much of it is common.
3. New *Send classes for FetchResponse to encapsulate send logic. Pretty straightforward.
3. All the test have been changed to make them multi-fetch by default. Because they make use of the response and the send, I've not added new tests for them.
4. I've removed the MultiFetchResponse classes along with associated java types, implicit conversions, request keys and tests.
Have a look. It's fairly massive so any and all feedback is welcome :)
was (Author: prashanth.menon):
Hi all,
Wasn't able to respond on Friday, but I've just wrapped up the last of the FetchRequest changes. I've attached a patch you can apply to 0.8. All tests should pass.
Details:
1. FetchRequest completely modified.
2. New FetchResponse, TopicData and PartitionData classes. The latter *Data classes can be shared with the producer side as much of it is common.
3. New *Send classes for FetchResponse to encapsulate send logic. Pretty straightforward.
3. All the test have been changed to make them multi-fetch by default. Because they make use of the response and the send, I've not added new tests for them.
4. I've removed the MultiFetchResponse classes along with associated java types, implicit conversions, request keys and tests.
Have a look. It's fairly massive so any and all feedback is welcome :)
> implement new producer and consumer request format
> --------------------------------------------------
>
> Key: KAFKA-240
> URL: https://issues.apache.org/jira/browse/KAFKA-240
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Labels: fetch, replication, wireprotocol
> Fix For: 0.8
>
> Attachments: KAFKA-240-FetchRequest-v1.patch
>
>
> We want to change the producer/consumer request/response format according to the discussion in the following wiki:
> https://cwiki.apache.org/confluence/display/KAFKA/New+Wire+Format+Proposal
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira