You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/13 20:57:53 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #7739: Build less bz2; fix case where cmake is present on system
nealrichardson opened a new pull request #7739:
URL: https://github.com/apache/arrow/pull/7739
There are a couple of things fixed here:
1. For reasons that were not clear, `bz2` was failing to build because `cmp: command not found`. It turns out that `cmp` is only called in `make test`, which we were calling via just `make` https://sourceware.org/git/?p=bzip2.git;a=blob;f=Makefile;h=b0fef950f361d84a5ec42749529fb34276e2de2d;hb=HEAD#l38. This was doing unnecessary work, aside from testing it was building command line utilities etc., so I made it only build libbz2. It's possible that we need to do [something different on MSVC](https://sourceware.org/git/?p=bzip2.git;a=blob;f=makefile.msc;h=799a18a5f1a7b084274ce1cd63997aeb4f9c2688;hb=HEAD) but I don't understand this well enough to be sure.
2. The arrow-r-nightly builds found a bug where the build uses system cmake instead of downloading it.
3. I fixed the install log reporting on CI builds, inadvertently turned off in my last patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657812040
Revision: eb3befdc517527c4a96d32fc0771798f7721a119
Submitted crossbow builds: [ursa-labs/crossbow @ actions-412](https://github.com/ursa-labs/crossbow/branches/all?query=actions-412)
|Task|Status|
|----|------|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-412-azure-test-r-rstudio-r-base-3.6-centos8)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7739: Build less bz2; fix case where cmake is present on system
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657792929
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657793098
https://issues.apache.org/jira/browse/ARROW-9443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm edited a comment on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
wesm edited a comment on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657809250
I don't think the bundled build ever worked on Windows (MSVC at least)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657811341
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657810915
If this bundled bz2 only works for `NOT MSVC` then this change should be "safe"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657808540
@wesm @kou do you know if we have any MSVC builds (github actions or crossbow) that build the bundled bz2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657809867
It seems like it could be possible by following the conda-forge recipe
https://github.com/conda-forge/bzip2-feedstock/blob/master/recipe/bld.bat
but would require some work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657792929
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #7739:
URL: https://github.com/apache/arrow/pull/7739
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657809250
I don't think the bundled build ever worked on Windows
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7739: ARROW-9443: [C++] Bundled bz2 build should only build libbz2
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7739:
URL: https://github.com/apache/arrow/pull/7739#issuecomment-657814683
As far as I know, we don't support bundled bzip2 for MSVC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org