You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Julian Sedding <js...@gmail.com> on 2016/11/09 08:16:40 UTC
oak-server defines two dependencies to o.a.sling.api
Hi all
oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped
dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two
different versions, even if in different scopes.
Removing the 2.3.0 dependency and leaving the to 2.15.0 test
dependency allows the build to pass.
Anyone opposed to this change?
Regards
Julian
Re: oak-server defines two dependencies to o.a.sling.api
Posted by Julian Sedding <js...@gmail.com>.
Hi Olli
I had to leave the test scoped dependency, as it is required to
compile OakServerTestSupport.
Regards
Julian
On Wed, Nov 9, 2016 at 10:03 AM, Julian Sedding <js...@gmail.com> wrote:
> Ok, I'll go ahead then and remove the dependencies from the pom.
>
> Regards
> Julian
>
> On Wed, Nov 9, 2016 at 9:59 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
>> On Wednesday 09 November 2016 09:42:09 Julian Sedding wrote:
>>> Hi Olli
>>
>> hi Julian,
>>
>>> The dependency to o.a.sling.api is only used for test, not for
>>> compile. The package o.a.sling.api is also not present in the
>>> oak-server bundle's import headers. So removing 2.3.0 (scope provided)
>>> should be safe IMHO.
>>
>> (SLING-6262)
>>
>>> Of course we can remove both dependencies from the pom and instead set
>>> 2.15.0 in OakServerTestSupport.
>>
>> Yes, in that case we should remove both and also clean up the other temporary
>> snapshots. I will come up with a new release of Testing PaxExam soon, so we
>> can remove all version overrides.
>>
>> Regards,
>> O.
>>
>>> Regards
>>> Julian
>>>
>>> PS: I created SLING-6262 to track this.
>>>
>>> On Wed, Nov 9, 2016 at 9:37 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
>>> > On Wednesday 09 November 2016 09:16:40 Julian Sedding wrote:
>>> >> Hi all
>>> >
>>> > hi Julian,
>>> >
>>> >> oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped
>>> >> dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two
>>> >> different versions, even if in different scopes.
>>> >>
>>> >> Removing the 2.3.0 dependency and leaving the to 2.15.0 test
>>> >> dependency allows the build to pass.
>>> >>
>>> >> Anyone opposed to this change?
>>> >
>>> > we had a discussion about dependency versions and agreed on using the
>>> > minimal version for compile. So keeping 2.3.0 in POM and setting the
>>> > version to 2.15.0 in OakServerTestSupport for tests is probably the
>>> > better solution.
>>> >
>>> > Regards,
>>> > O.
>>> >
>>> >> Regards
>>> >> Julian
>>
>>
Re: oak-server defines two dependencies to o.a.sling.api
Posted by Julian Sedding <js...@gmail.com>.
Ok, I'll go ahead then and remove the dependencies from the pom.
Regards
Julian
On Wed, Nov 9, 2016 at 9:59 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
> On Wednesday 09 November 2016 09:42:09 Julian Sedding wrote:
>> Hi Olli
>
> hi Julian,
>
>> The dependency to o.a.sling.api is only used for test, not for
>> compile. The package o.a.sling.api is also not present in the
>> oak-server bundle's import headers. So removing 2.3.0 (scope provided)
>> should be safe IMHO.
>
> (SLING-6262)
>
>> Of course we can remove both dependencies from the pom and instead set
>> 2.15.0 in OakServerTestSupport.
>
> Yes, in that case we should remove both and also clean up the other temporary
> snapshots. I will come up with a new release of Testing PaxExam soon, so we
> can remove all version overrides.
>
> Regards,
> O.
>
>> Regards
>> Julian
>>
>> PS: I created SLING-6262 to track this.
>>
>> On Wed, Nov 9, 2016 at 9:37 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
>> > On Wednesday 09 November 2016 09:16:40 Julian Sedding wrote:
>> >> Hi all
>> >
>> > hi Julian,
>> >
>> >> oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped
>> >> dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two
>> >> different versions, even if in different scopes.
>> >>
>> >> Removing the 2.3.0 dependency and leaving the to 2.15.0 test
>> >> dependency allows the build to pass.
>> >>
>> >> Anyone opposed to this change?
>> >
>> > we had a discussion about dependency versions and agreed on using the
>> > minimal version for compile. So keeping 2.3.0 in POM and setting the
>> > version to 2.15.0 in OakServerTestSupport for tests is probably the
>> > better solution.
>> >
>> > Regards,
>> > O.
>> >
>> >> Regards
>> >> Julian
>
>
Re: oak-server defines two dependencies to o.a.sling.api
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 09 November 2016 09:42:09 Julian Sedding wrote:
> Hi Olli
hi Julian,
> The dependency to o.a.sling.api is only used for test, not for
> compile. The package o.a.sling.api is also not present in the
> oak-server bundle's import headers. So removing 2.3.0 (scope provided)
> should be safe IMHO.
(SLING-6262)
> Of course we can remove both dependencies from the pom and instead set
> 2.15.0 in OakServerTestSupport.
Yes, in that case we should remove both and also clean up the other temporary
snapshots. I will come up with a new release of Testing PaxExam soon, so we
can remove all version overrides.
Regards,
O.
> Regards
> Julian
>
> PS: I created SLING-6262 to track this.
>
> On Wed, Nov 9, 2016 at 9:37 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
> > On Wednesday 09 November 2016 09:16:40 Julian Sedding wrote:
> >> Hi all
> >
> > hi Julian,
> >
> >> oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped
> >> dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two
> >> different versions, even if in different scopes.
> >>
> >> Removing the 2.3.0 dependency and leaving the to 2.15.0 test
> >> dependency allows the build to pass.
> >>
> >> Anyone opposed to this change?
> >
> > we had a discussion about dependency versions and agreed on using the
> > minimal version for compile. So keeping 2.3.0 in POM and setting the
> > version to 2.15.0 in OakServerTestSupport for tests is probably the
> > better solution.
> >
> > Regards,
> > O.
> >
> >> Regards
> >> Julian
Re: oak-server defines two dependencies to o.a.sling.api
Posted by Julian Sedding <js...@gmail.com>.
Hi Olli
The dependency to o.a.sling.api is only used for test, not for
compile. The package o.a.sling.api is also not present in the
oak-server bundle's import headers. So removing 2.3.0 (scope provided)
should be safe IMHO.
Of course we can remove both dependencies from the pom and instead set
2.15.0 in OakServerTestSupport.
Regards
Julian
PS: I created SLING-6262 to track this.
On Wed, Nov 9, 2016 at 9:37 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
> On Wednesday 09 November 2016 09:16:40 Julian Sedding wrote:
>> Hi all
>
> hi Julian,
>
>> oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped
>> dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two
>> different versions, even if in different scopes.
>>
>> Removing the 2.3.0 dependency and leaving the to 2.15.0 test
>> dependency allows the build to pass.
>>
>> Anyone opposed to this change?
>
> we had a discussion about dependency versions and agreed on using the minimal
> version for compile. So keeping 2.3.0 in POM and setting the version to 2.15.0
> in OakServerTestSupport for tests is probably the better solution.
>
> Regards,
> O.
>
>> Regards
>> Julian
>
Re: oak-server defines two dependencies to o.a.sling.api
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 09 November 2016 09:16:40 Julian Sedding wrote:
> Hi all
hi Julian,
> oak-server has a dependency to o.a.sling.api-2.3.0 and a test scoped
> dependency to o.a.sling.api-2.15.0. IFAIK maven cannot handle two
> different versions, even if in different scopes.
>
> Removing the 2.3.0 dependency and leaving the to 2.15.0 test
> dependency allows the build to pass.
>
> Anyone opposed to this change?
we had a discussion about dependency versions and agreed on using the minimal
version for compile. So keeping 2.3.0 in POM and setting the version to 2.15.0
in OakServerTestSupport for tests is probably the better solution.
Regards,
O.
> Regards
> Julian