You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/11/22 11:01:51 UTC
[GitHub] [lucene] iverase opened a new pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes
iverase opened a new pull request #462:
URL: https://github.com/apache/lucene/pull/462
In pre-8.6 indexes, high dimensional trees (numDims > 1) were constructed as fully balanced trees but the BKD reader always assumes that trees are unbalanced as it is the case from Lucene 8.6 onwards. Note as well that in Lucene 8.6 we added a new Points Format codec and therefore this sure only shows on the Lucene 60 codec.
In order to test the change, I ported the BKD writer from Lucene 8.5 to the backwards codec in order to build balanced trees.
While fixing this, I discover that the SimpleTextBKDtree is always balance and it is fixed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #462:
URL: https://github.com/apache/lucene/pull/462#issuecomment-979054439
OK, fair enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on a change in pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes
Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #462:
URL: https://github.com/apache/lucene/pull/462#discussion_r756647618
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/Lucene60PointsWriter.java
##########
@@ -270,8 +256,7 @@ public void finish() throws IOException {
Lucene60PointsFormat.INDEX_EXTENSION);
// Write index file
try (IndexOutput indexOut =
- EndiannessReverserUtil.createOutput(
- writeState.directory, indexFileName, writeState.context)) {
+ writeState.directory.createOutput(indexFileName, writeState.context)) {
Review comment:
I'm confused about this change, why do we no longer need to reverse the byte order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase commented on pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #462:
URL: https://github.com/apache/lucene/pull/462#issuecomment-978957321
Porting TestBKD is tricky as that test might generate balanced trees fir the 1D case, something we never do in the codec. I think `TestLucene60PointsFormat` provides enough coverage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase commented on a change in pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes
Posted by GitBox <gi...@apache.org>.
iverase commented on a change in pull request #462:
URL: https://github.com/apache/lucene/pull/462#discussion_r756674099
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene60/Lucene60PointsWriter.java
##########
@@ -270,8 +256,7 @@ public void finish() throws IOException {
Lucene60PointsFormat.INDEX_EXTENSION);
// Write index file
try (IndexOutput indexOut =
- EndiannessReverserUtil.createOutput(
- writeState.directory, indexFileName, writeState.context)) {
+ writeState.directory.createOutput(indexFileName, writeState.context)) {
Review comment:
That was an oversight .In reality it does not matter as in that IndexOutput we are not writing primitives, but still I have updated it and wrap it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase merged pull request #462: LUCENE-9820: PointTree#size() should handle the case of balanced tree in pre-8.6 indexes
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #462:
URL: https://github.com/apache/lucene/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org