You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/16 02:41:38 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #12639: MINOR: [Python][CI] Ignore parquet-encryption if parquet not enabled

cyb70289 commented on a change in pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#discussion_r827577004



##########
File path: python/setup.py
##########
@@ -421,7 +421,8 @@ def _bundle_cython_cpp(self, name, lib_path):
     def _failure_permitted(self, name):
         if name == '_parquet' and not self.with_parquet:
             return True
-        if name == '_parquet_encryption' and not self.with_parquet_encryption:
+        if name == '_parquet_encryption' and \
+                not (self.with_parquet and self.with_parquet_encryption):

Review comment:
       From the name, looks to me `with_parquet_encryption == True` implies `with_parquet == True`, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org