[jira] [Commented] (VCL-1029) add a section for managing affiliations to Site Configuration

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989286#comment-15989286 ] 

ASF subversion and git services commented on VCL-1029:
------------------------------------------------------

Commit 1793126 from [~jfthomps] in branch 'vcl/trunk'
[ https://svn.apache.org/r1793126 ]

VCL-1029 - add a section for managing affiliations to Site Configuration

siteconfig.php:
-modified generalOptions: reordered several options; added conditional to only print AffilShibName block if user has global config permission or the user's affiliation is not Local
-modified AffilTextVariable: added $updatefailmsg, $affils, $allowempty, $allowglobalempty, $globalid, and initializations for them in the __construct function
-modified AffilTextVariable::validateValue: escaped any slashes in $this->constraints before doing the preg_match
-modified AffilTextVariable::getHTML: modified to better handle users not having global site config so that they see the default value from the Global setting and can set the value to an empty string to cause the default value to be used
-modified AffilTextVariable::AJaddAffiliationSetting: set $affils from $this->affils instead of calling getAffiliations
-modified AffilTextVariable::AJupdateAllSettings: modified to better handle users not having global site config so that they can set the value to an empty string to cause the default value to be used
-modified AffilHelpAddress: set $this->allowempty to 1
-modified AffilHelpAddress::setValue: modified to handle $value being NULL
-added AffilWebAddress
-modified AffilKMSserver: set $this->allowempty to 1; set $this->allowglobalempty to 1
-modified AffilTheme: set $this->allowempty to 1
-modified AffilTheme::deleteValue: added code to set theme value to NULL in database rather than just returning 0
-added AffilShibOnly
-added AffilShibName

states.php:
-added affilwebaddress classmapping
-added affilshibonly classmapping
-added affilshibname classmapping

utils.php: modified getAffiliationTheme: updated query to return theme from Global affiliation if passed in affiliation's setting is NULL; if no value found for either, return DEFAULTTHEME setting

siteconfig.js:
-modified AffilTextVariable.prototype.addAffiliationSettingCBextra: fixed problem when adding a new value where the savekeys value was getting an empty string in the list
-modified AffilTextVariable.prototype.saveSettings: if a value of 0 is going to be submitted, change it to 'zero' so that the php function processInputVar will handle it correctly
-added affilwebaddr
-added affilshibonly
-added affilshibname
-modified messages.prototype.init: changed setTimeout from calling this.init to calling messages.init or messages.prototype.init, depending on which one exists

> add a section for managing affiliations to Site Configuration
> -------------------------------------------------------------
>
>                 Key: VCL-1029
>                 URL: https://issues.apache.org/jira/browse/VCL-1029
>             Project: VCL
>          Issue Type: Improvement
>          Components: web gui (frontend)
>            Reporter: Josh Thompson
>             Fix For: 2.5
>
>
> The database must be directly modified to add or remove affiliations. Admins should not need to directly modify the database, especially for something as simple as adding an affiliation. This can easily be added to the Site Configuration page.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)