You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Venki Korukanti <ve...@gmail.com> on 2015/05/05 00:09:08 UTC
Re: Review Request 33662: DRILL-2902: Add support for context
functions:
user (synonyms session_user and system_user) and current_schema
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33662/
-----------------------------------------------------------
(Updated May 4, 2015, 10:09 p.m.)
Review request for drill and Mehant Baid.
Changes
-------
Rebase and small change in UDF to use int as workspace variable instead of VarCharHolder.
Repository: drill-git
Description
-------
Please see https://issues.apache.org/jira/browse/DRILL-2902 for details.
Apart from adding new UDFs, also refactored the context information stored in PlanFragment into a separate message. Refactored QueryDateTimeInfo into ContextInformation to provide one interface for all query context replated info.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 4576eb4
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java 9c932d6
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 09a7568
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 6414f56
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryDateTimeInfo.java f3cc666
exec/java-exec/src/main/java/org/apache/drill/exec/ops/UdfUtilities.java 1cdece1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java 66ba229
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 527bac0
exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java 8efb9e7
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 4249cbe
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestContextFunctions.java PRE-CREATION
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java 04e1980
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java 9758eb0
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java 6a6a7e0
exec/java-exec/src/test/java/org/apache/drill/exec/pop/TestFragmentChecker.java 32e3bf9
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestCustomUserAuthenticator.java 70d43b6
exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java 604f375
exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java 508b10c
protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 813d961
protocol/src/main/java/org/apache/drill/exec/proto/SchemaBitControl.java 5e7562e
protocol/src/main/java/org/apache/drill/exec/proto/beans/PlanFragment.java f6fbce1
protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java PRE-CREATION
protocol/src/main/protobuf/BitControl.proto 0424725
Diff: https://reviews.apache.org/r/33662/diff/
Testing
-------
Added unittests to test the new UDFs added in the patch.
Thanks,
Venki Korukanti
Re: Review Request 33662: DRILL-2902: Add support for context
functions:
user (synonyms session_user and system_user) and current_schema
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33662/#review82537
-----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java
<https://reviews.apache.org/r/33662/#comment133277>
Should we check if the allocated buffer has enough space?
- Mehant Baid
On May 4, 2015, 10:09 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33662/
> -----------------------------------------------------------
>
> (Updated May 4, 2015, 10:09 p.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see https://issues.apache.org/jira/browse/DRILL-2902 for details.
>
> Apart from adding new UDFs, also refactored the context information stored in PlanFragment into a separate message. Refactored QueryDateTimeInfo into ContextInformation to provide one interface for all query context replated info.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 4576eb4
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java 9c932d6
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 09a7568
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 6414f56
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryDateTimeInfo.java f3cc666
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/UdfUtilities.java 1cdece1
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java 66ba229
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 527bac0
> exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java 8efb9e7
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 4249cbe
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestContextFunctions.java PRE-CREATION
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java 04e1980
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java 9758eb0
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java 6a6a7e0
> exec/java-exec/src/test/java/org/apache/drill/exec/pop/TestFragmentChecker.java 32e3bf9
> exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestCustomUserAuthenticator.java 70d43b6
> exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java 604f375
> exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java 508b10c
> protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 813d961
> protocol/src/main/java/org/apache/drill/exec/proto/SchemaBitControl.java 5e7562e
> protocol/src/main/java/org/apache/drill/exec/proto/beans/PlanFragment.java f6fbce1
> protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java PRE-CREATION
> protocol/src/main/protobuf/BitControl.proto 0424725
>
> Diff: https://reviews.apache.org/r/33662/diff/
>
>
> Testing
> -------
>
> Added unittests to test the new UDFs added in the patch.
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33662: DRILL-2902: Add support for context
functions:
user (synonyms session_user and system_user) and current_schema
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33662/#review82541
-----------------------------------------------------------
Ship it!
Ship It!
- Mehant Baid
On May 4, 2015, 10:09 p.m., Venki Korukanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33662/
> -----------------------------------------------------------
>
> (Updated May 4, 2015, 10:09 p.m.)
>
>
> Review request for drill and Mehant Baid.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Please see https://issues.apache.org/jira/browse/DRILL-2902 for details.
>
> Apart from adding new UDFs, also refactored the context information stored in PlanFragment into a separate message. Refactored QueryDateTimeInfo into ContextInformation to provide one interface for all query context replated info.
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 4576eb4
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java 9c932d6
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 09a7568
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 6414f56
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryDateTimeInfo.java f3cc666
> exec/java-exec/src/main/java/org/apache/drill/exec/ops/UdfUtilities.java 1cdece1
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java 66ba229
> exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 527bac0
> exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java 8efb9e7
> exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 4249cbe
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestContextFunctions.java PRE-CREATION
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java 04e1980
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java 9758eb0
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java 6a6a7e0
> exec/java-exec/src/test/java/org/apache/drill/exec/pop/TestFragmentChecker.java 32e3bf9
> exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestCustomUserAuthenticator.java 70d43b6
> exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java 604f375
> exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java 508b10c
> protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 813d961
> protocol/src/main/java/org/apache/drill/exec/proto/SchemaBitControl.java 5e7562e
> protocol/src/main/java/org/apache/drill/exec/proto/beans/PlanFragment.java f6fbce1
> protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java PRE-CREATION
> protocol/src/main/protobuf/BitControl.proto 0424725
>
> Diff: https://reviews.apache.org/r/33662/diff/
>
>
> Testing
> -------
>
> Added unittests to test the new UDFs added in the patch.
>
>
> Thanks,
>
> Venki Korukanti
>
>
Re: Review Request 33662: DRILL-2902: Add support for context
functions:
user (synonyms session_user and system_user) and current_schema
Posted by Venki Korukanti <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33662/
-----------------------------------------------------------
(Updated May 5, 2015, 6:45 p.m.)
Review request for drill and Mehant Baid.
Changes
-------
addressed review comment.
Repository: drill-git
Description
-------
Please see https://issues.apache.org/jira/browse/DRILL-2902 for details.
Apart from adding new UDFs, also refactored the context information stored in PlanFragment into a separate message. Refactored QueryDateTimeInfo into ContextInformation to provide one interface for all query context replated info.
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java 4576eb4
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/ContextFunctions.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java 9c932d6
exec/java-exec/src/main/java/org/apache/drill/exec/ops/ContextInformation.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java 09a7568
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java 6414f56
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryDateTimeInfo.java f3cc666
exec/java-exec/src/main/java/org/apache/drill/exec/ops/UdfUtilities.java 1cdece1
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java 66ba229
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java 527bac0
exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java 8efb9e7
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java 4249cbe
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestContextFunctions.java PRE-CREATION
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java 04e1980
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestLocalExchange.java 9758eb0
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/partitionsender/TestPartitionSender.java 6a6a7e0
exec/java-exec/src/test/java/org/apache/drill/exec/pop/TestFragmentChecker.java 32e3bf9
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestCustomUserAuthenticator.java 70d43b6
exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestExceptionInjection.java 604f375
exec/java-exec/src/test/java/org/apache/drill/exec/testing/TestPauseInjection.java 508b10c
protocol/src/main/java/org/apache/drill/exec/proto/BitControl.java 813d961
protocol/src/main/java/org/apache/drill/exec/proto/SchemaBitControl.java 5e7562e
protocol/src/main/java/org/apache/drill/exec/proto/beans/PlanFragment.java f6fbce1
protocol/src/main/java/org/apache/drill/exec/proto/beans/QueryContextInformation.java PRE-CREATION
protocol/src/main/protobuf/BitControl.proto 0424725
Diff: https://reviews.apache.org/r/33662/diff/
Testing
-------
Added unittests to test the new UDFs added in the patch.
Thanks,
Venki Korukanti