[jira] [Commented] (OFBIZ-12473) CheckStyleMain Task is Failing in 18.12.04

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463944#comment-17463944 ] 

ASF subversion and git services commented on OFBIZ-12473:
---------------------------------------------------------

Commit 99441469dc71d00edd62239a6c0ffe48c53ab438 in ofbiz-framework's branch refs/heads/release18.12 from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9944146 ]

Fixed: CheckStyleMain Task is Failing in 18.12.04 (OFBIZ-12473)

On Windows checkstyle reports that it misses a NewLine at EOF for all files, not
on *nix

Currently:
1. We don't care about checkstyle in branches (we will in 22.01 where it'll 0 errors)
2. Proof is we check for 38802 but the errors are actually 38508 in *nix

Solution: change from 38802 to 39638 to pass also on Windows

Thanks: David S Hunter for report


> CheckStyleMain Task is Failing in 18.12.04
> ------------------------------------------
>
>                 Key: OFBIZ-12473
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12473
>             Project: OFBiz
>          Issue Type: Bug
>          Components: Gradle
>    Affects Versions: 18.12.04
>         Environment: Windows 10
>            Reporter: David S Hunter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>
> When doing ofbiz cleanAll loadAll, the follwing the output: 
> ************************************************
> > Task :clean
> > Task :cleanCatalina
> > Task :cleanData
> > Task :cleanDownloads
> > Task :cleanEclipseClasspath UP-TO-DATE
> > Task :cleanEclipseJdt UP-TO-DATE
> > Task :cleanEclipseProject UP-TO-DATE
> > Task :cleanEclipse UP-TO-DATE
> > Task :cleanFooterFiles
> > Task :cleanIndexes
> > Task :cleanLogs
> > Task :cleanOutput
> > Task :cleanTempfiles
> > Task :cleanUploads
> > Task :cleanXtra
> > Task :cleanAll
> > Task :compileJava
> > Task :compileGroovy
> > Task :processResources
> > Task :classes
> > Task :jar
> > Task :assemble
> > Task :checkstyleMain
> > Task :checkstyleMain FAILED
> FAILURE: Build failed with an exception.
> * What went wrong:
> Execution failed for task ':checkstyleMain'.
> > Checkstyle rule violations were found. See the report at: file:///C:/Users/david/Documents/apache-ofbiz-18.12.04/build/reports/checkstyle/main.html
>   Checkstyle files with violations: 1157
>   Checkstyle violations by severity: [error:39638]
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
> * Get more help at https://help.gradle.org
> BUILD FAILED in 1m 30s
> 20 actionable tasks: 16 executed, 4 up-to-dates
> ******************************
> I have no idea what is wrong. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)