[GitHub] [incubator-echarts] pissang opened a new pull request #11514: fix(axis): fix extra ticks added caused by rounding error. add test cases for splitArea

[GitBox <gi...@apache.org>]

pissang opened a new pull request #11514: fix(axis): fix extra ticks added caused by rounding error. add test cases for splitArea
URL: https://github.com/apache/incubator-echarts/pull/11514
 
 
   Hi, this pull request has two changes:
   
   1. Added two test cases for splitArea color issue. From #10948 #11438 
   
   2. Fix rounding error when calculating ticks. Which will lead to extra ticks being added in the code https://github.com/apache/incubator-echarts/blob/master/src/coord/Axis.js#L337
   
   <img width="519" alt="MacHi 2019-10-29 22-41-56" src="https://user-images.githubusercontent.com/841551/67780050-7e2b7780-faa0-11e9-8400-cacbdcadcd17.png">
   
   This bug will lead to wrong splitArea color in a specific resolution in the case from #11438 
   
   <img width="1611" alt="MacHi 2019-10-29 23-07-06" src="https://user-images.githubusercontent.com/841551/67780298-e0847800-faa0-11e9-965b-39e3605c152b.png">
   
   (The first color should be green instead of red)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org