You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/23 19:03:22 UTC

[GitHub] [arrow] dianaclarke opened a new pull request #9557: ARROW-11746: [Developer][Archery] Fix prefer real time check

dianaclarke opened a new pull request #9557:
URL: https://github.com/apache/arrow/pull/9557


   See: https://issues.apache.org/jira/browse/ARROW-11746
   
   Google Benchmark adds `/real_time` to the end of the benchmark name to indicate if the `real_time` observation should be preferred over the `cpu_time` observation.
   
   https://github.com/google/benchmark/blob/af72911f2fe6b8114564614d2db17a449f8c4af0/src/benchmark_register.cc#L222
   
   Example: `AllocateDeallocate<Jemalloc>/size:1048576/real_time`
   
   Archery is looking for `"/realtime"`, not `"/real_time"` though.
   
   ```
    @property
    def is_realtime(self):
        """ Indicate if the preferred value is realtime instead of cputime. """
        return self.name.find("/realtime") != -1
   ```
   
   In addition to fixing this, I have also added unit tests for the various cases I've worked with recently in the following PRs.
   
   ARROW-11573: [Developer][Archery] Google benchmark now reports run type
   https://github.com/apache/arrow/pull/9457
   
   ARROW-11575: [Developer][Archery] Expose execution time in benchmark results
   https://github.com/apache/arrow/pull/9458
   
   ARROW-11517: [Developer][Archery] Report both items and bytes per second
   https://github.com/apache/arrow/pull/9431


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] dianaclarke commented on a change in pull request #9557: ARROW-11746: [Developer][Archery] Fix prefer real time check

Posted by GitBox <gi...@apache.org>.
dianaclarke commented on a change in pull request #9557:
URL: https://github.com/apache/arrow/pull/9557#discussion_r581503176



##########
File path: dev/archery/tests/test_benchmarks.py
##########
@@ -88,7 +143,7 @@ def test_omits_aggregates():
         "name": name,
         "unit": "ns",
         "less_is_better": True,
-        "values": [1778.6004847419827],
+        "values": [1835.3137357788837],

Review comment:
       This change is a manifestation of the underlying bug this pull request fixes. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9557: ARROW-11746: [Developer][Archery] Fix prefer real time check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9557:
URL: https://github.com/apache/arrow/pull/9557#issuecomment-784477305


   https://issues.apache.org/jira/browse/ARROW-11746


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] bkietz closed pull request #9557: ARROW-11746: [Developer][Archery] Fix prefer real time check

Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #9557:
URL: https://github.com/apache/arrow/pull/9557


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org