You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/08/21 21:43:37 UTC

[GitHub] merlimat commented on a change in pull request #2420: [client] add properties to producer for cpp & python client

merlimat commented on a change in pull request #2420: [client] add properties to producer for cpp & python client
URL: https://github.com/apache/incubator-pulsar/pull/2420#discussion_r211769327
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/__init__.py
 ##########
 @@ -321,7 +321,8 @@ def create_producer(self, topic,
                         batching_max_messages=1000,
                         batching_max_allowed_size_in_bytes=128*1024,
                         batching_max_publish_delay_ms=10,
-                        message_routing_mode=PartitionsRoutingMode.RoundRobinDistribution
+                        message_routing_mode=PartitionsRoutingMode.RoundRobinDistribution,
+                        properties=None,
 
 Review comment:
   We should add `properties` to the pydoc string below

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services